Closed Bug 1146460 Opened 5 years ago Closed 5 years ago

Fix ToolboxFullscreenState

Categories

(DevTools :: WebIDE, defect)

35 Branch
x86
macOS
defect
Not set

Tracking

(firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox39 --- fixed

People

(Reporter: jfong, Assigned: jfong)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch Bug1146460.patch (obsolete) — Splinter Review
hbox does not appear to abide by the height rules and seems to only hide correctly when display: none is set. Open to changing this if there is another option, but I could not find any info anywhere.
Attachment #8581999 - Flags: review?(jryans)
Comment on attachment 8581999 [details] [diff] [review]
Bug1146460.patch

Review of attachment 8581999 [details] [diff] [review]:
-----------------------------------------------------------------

Great, seems to restore things correctly.  We'll think more in separate bugs about what really makes sense in the sidebar case.

::: browser/devtools/webide/themes/webide.css
@@ +328,5 @@
>    min-height: 0;
>    max-height: 0;
>  }
>  
> +#notificationbox[toolboxfullscreen] > hbox {

Let's give the |hbox| an ID and style based on that.  Give it your best shot at naming! :)
Attachment #8581999 - Flags: review?(jryans) → review+
Blocks: 1126432
Keywords: regression
Attached patch Bug1146460.patchSplinter Review
Attachment #8581999 - Attachment is obsolete: true
Attachment #8582019 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cd66c01ef641
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.