Fix ToolboxFullscreenState

RESOLVED FIXED in Firefox 39

Status

RESOLVED FIXED
3 years ago
2 months ago

People

(Reporter: jfong, Assigned: jfong)

Tracking

({regression})

35 Branch
Firefox 39
x86
Mac OS X
regression

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8581999 [details] [diff] [review]
Bug1146460.patch

hbox does not appear to abide by the height rules and seems to only hide correctly when display: none is set. Open to changing this if there is another option, but I could not find any info anywhere.
Attachment #8581999 - Flags: review?(jryans)
Comment on attachment 8581999 [details] [diff] [review]
Bug1146460.patch

Review of attachment 8581999 [details] [diff] [review]:
-----------------------------------------------------------------

Great, seems to restore things correctly.  We'll think more in separate bugs about what really makes sense in the sidebar case.

::: browser/devtools/webide/themes/webide.css
@@ +328,5 @@
>    min-height: 0;
>    max-height: 0;
>  }
>  
> +#notificationbox[toolboxfullscreen] > hbox {

Let's give the |hbox| an ID and style based on that.  Give it your best shot at naming! :)
Attachment #8581999 - Flags: review?(jryans) → review+
Blocks: 1126432
Keywords: regression
(Assignee)

Comment 3

3 years ago
Created attachment 8582019 [details] [diff] [review]
Bug1146460.patch
Attachment #8581999 - Attachment is obsolete: true
Attachment #8582019 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cd66c01ef641
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.