Closed Bug 1146472 Opened 7 years ago Closed 7 years ago

Use JSOP_NEWOBJECT even if the script is not compile-and-go

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(2 files)

Use JSOP_NEWOBJECT as needed even if the script is not compile-and-go
2.68 KB, patch
luke
: review+
Details | Diff | Splinter Review
part 1. Don't do object-kind guessing for object literal templates in scripts, since we in fact know exactly how many slots we want them to have and hence what the kind should be
3.14 KB, patch
terrence
: review+
Details | Diff | Splinter Review 
We now have XDR and cloning support for this stuff, so it should be safe.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8581871 - Flags: review?(luke) → review+
Argh.  This is hitting startup asserts in Firefox.

Patch coming up that slides under the above and fixed it.
Attachment #8581990 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/0dbb27833e88
https://hg.mozilla.org/mozilla-central/rev/8bccbbf668c6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.