Closed Bug 1146486 Opened 8 years ago Closed 8 years ago

The generic reading list thumbnail graphic is stretched too big and on white background

Categories

(Firefox Graveyard :: Reading List, defect)

Product:
Firefox Graveyard
Component:
Reading List
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox38 verified, firefox39 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 39
Tracking Flags:
Tracking Status
firefox38 --- verified
firefox39 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Screenshot of bug
24.47 KB, image/png
Details
After patch
23.78 KB, image/png
Details
Patch
1.95 KB, patch
florian
: review+
Details | Diff | Splinter Review 
Now that we switched to using cover for provided-backgrounds, we should still be using contain for the fallback icon or else it will be stretched to fit the full preview size which isn't to spec. We should also revert back to the spec'd background-color, now that we are using background-size:cover for provided background images.
Flags: qe-verify-
Flags: firefox-backlog+
Blocks: 1132074
Iteration: 39.3 - 30 Mar → 39.2 - 23 Mar
Attached image After patch — 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch
        — 
          — Splinter Review
      

    


  

        Attachment #8581833 -
        Flags: review?(florian)

        Attachment #8581833 -
        Flags: review?(florian) → review+
Iteration: 39.2 - 23 Mar → 39.3 - 30 Mar

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/cd9dda8f4cc1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox39:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39

    
    

    
  
Verified fixed on Nightly 39.0a1 (2015-03-29) and Aurora 38.0a2 (2015-03-29), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED

          status-firefox38:
          fixed → verified

          status-firefox39:
          fixed → verified
QA Contact: andrei.vaida
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.