1146495 - Private browsing indicator not shown when startup with "-private" command line switch

Status: NEW

(Firefox :: Private Browsing, defect)

Description

[Peter Wong]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150320202338

Steps to reproduce:

Add "-private" switch to firefox shortcut.
Start firefox by the double click the shortcut.


Actual results:

Firefox start with the "You're browsing privately" tab.
But the private browsing window indicator is not shown.


Expected results:

The purple private browsing window indicator should be shown on the right hand side of the titlebar.

Comment 1

[Josh Matthews [:jdm]]

This is an intentional choice - we explicitly check in http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/PrivateBrowsingUtils.jsm?force=1#54 for whether the `-private` flag was present at startup, and we base various UI decisions on that check.

Comment 2

[Ηλίας Ηλιάδης]

So  
(In reply to Josh Matthews [:jdm] from comment #1)
> This is an intentional choice - we explicitly check in
> http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/
> PrivateBrowsingUtils.jsm?force=1#54 for whether the `-private` flag was
> present at startup, and we base various UI decisions on that check.

what is presented by the title is confirmed. Please change status either to VERIFIED or to INVALID.

Any way, why any UI decisions especially for private browsing are based on command line and private browsing UI is differentiate based on that? People (like me) get confused if the private browsing window does not show the indicator. Personally I opened many new private browsing windows before I understand that is not possible to have a real private browsing window from one started from command line. Initially I thought was some "phishing" page.

Comment 3

[Josh Matthews [:jdm]]

I suspect the code I previously linked is conflating our "always private browsing mode" with "first window opened is a private window", which is not what we should be doing.