1146501 - Please deploy pushgo 1.5rc5 to STAGE for SimplePush servers

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: WebPush, defect)

Description

[JR Conlin [:jrconlin,:jconlin]]

https://github.com/mozilla-services/pushgo/releases/tag/1.5rc5

This version does not need to be deployed to loop servers, however it would do no harm.

NOTE: 
Please add the following flag to the SimplePush config.toml file for STAGE servers

[endpoint]
enable_cors = true

Comment 1

[Richard Pappalardo [:rpapa][:rpappalardo]]

thanks, JR.  Are we going to skip over 1.5rc4 and move forward with 1.5rc5?

If so I'll resolve this the other ticket: Bug 1142225 - Please deploy pushgo 1.5rc4 to SimplePush Stage
and schedule time for testing the latest one

Comment 2

[JR Conlin [:jrconlin,:jconlin]]

1.5rc5 simply adds optional CORS support. If you have not already tested 1.5, it's fine to skip rc4 in favor of this version.

Comment 3

[Richard Pappalardo [:rpapa][:rpappalardo]]

Hi Ben, I have loadtesting and deploys for loop-server, shavar scheduled this week.  Does this release need to be deployed this week or could we schedule for next?

Comment 4

[Jeremy Orem [:oremj]]

1.5rc5 has been deployed to STAGE.

Comment 5

[JR Conlin [:jrconlin,:jconlin]]

(In reply to Richard Pappalardo [:rpapa][:rpappalardo] from comment #3)
> Hi Ben, I have loadtesting and deploys for loop-server, shavar scheduled
> this week.  Does this release need to be deployed this week or could we
> schedule for next?

:rpapa, this patch only needs to go to Stage. There should be no impact to planned the 1.5 production release schedule.

Comment 6

[JR Conlin [:jrconlin,:jconlin]]

(In reply to Jeremy Orem [:oremj] from comment #4)
> 1.5rc5 has been deployed to STAGE.

oremj, did you include the config.toml change specified above? I'm not seeing the proper response from the server.

Comment 7

[Jeremy Orem [:oremj]]

Sorry, missed that. Redeployed with enable_cors = true

Comment 8

[Richard Pappalardo [:rpapa][:rpappalardo]]

Hi Jeremy, 
There's still an issue with this fix.  Can you please grant stage access to JR so he can troubleshoot directly on stage?  
Thanks!

Comment 9

[Jeremy Orem [:oremj]]

Access has been granted to: 172.31.58.152. I've also added him to the simplepush stage user list, so on the next deploy he will automatically have access to all of the nodes. Let me know if I should redeploy, so he has access to all now.

Comment 10

[Richard Pappalardo [:rpapa][:rpappalardo]]

------------------
RELEASE NOTES
------------------
https://github.com/mozilla-services/pushgo/releases

COMPARISONS
https://github.com/mozilla-services/pushgo/compare/1.5rc1...1.5rc4
https://github.com/mozilla-services/pushgo/compare/1.5rc4...1.5rc5

TAGS
https://github.com/mozilla-services/pushgo/releases/tag/1.5rc5
https://github.com/mozilla-services/pushgo/commit/9bc98a5eb0d5c7a1f2713dacd87a862b9fd9c62b

------------------
TEST SUMMARY
------------------

unit tests on tag -OK
loadtesting OK per Ben
end-2-end call verification OK in stage

e2e test on stage using an older build of findmydevice on B2G and setting:
user_pref("services.push.serverURL", "wss://push.stage.mozaws.net/");

Verifying stage.

Comment 11

[Richard Pappalardo [:rpapa][:rpappalardo]]

see:
Bug 1148653 - Please deploy pushgo 1.5 to SimplePush Production