If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Australis 'swoop' shape path is not as smooth/rounded as on desktop

RESOLVED WORKSFORME

Status

()

Firefox for iOS
Theme & Visual Design
RESOLVED WORKSFORME
3 years ago
2 years ago

People

(Reporter: jgruen, Assigned: darrin)

Tracking

unspecified
All
iOS 8

Firefox Tracking Flags

(fxios+)

Details

(Whiteboard: [qx])

Attachments

(4 attachments)

(Reporter)

Description

3 years ago
Created attachment 8581874 [details]
Different Bezier paths on desktop and iOS

Attaching a picture for clarity. The Australis 'swoop' path on iOS appears to go vertical about mid-way through. Lacks the overall smoothness of it's desktop counterpart
(Reporter)

Comment 1

3 years ago
(In reply to [:jgruen] from comment #0)
> Created attachment 8581874 [details]
> Different Bezier paths on desktop and iOS
> 
> Attaching a picture for clarity. The Australis 'swoop' path on iOS appears
> to go vertical about mid-way through. Lacks the overall smoothness of it's*
> desktop counterpart

*its
tracking-fennec: --- → ?
OS: Mac OS X → iOS 8
Hardware: x86 → All
On Android, we don't use exact same curve as Australis. That was an intentional decision because of both the implementation, and the device type, made with the considerations of Shorlander. 

But, that being said, the screen shot does look a bit different to even Android.

Wes, are we using the same curve as Android?
Flags: needinfo?(wjohnston)
Yes. I haven't overlaid them, but all the parameters are exactly the same.
Flags: needinfo?(wjohnston)
tracking-fennec: ? → +
(Assignee)

Updated

2 years ago
Assignee: nobody → dhenein
(Assignee)

Comment 4

2 years ago
You said you had the desktop one Wes?
Flags: needinfo?(wjohnston)
I found something in this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=921051 from when Desktop was going to ship SVG. It will take a little division to covert it to our w/h units. I hadn't got that far. Maybe someone in UX has a better version.
Flags: needinfo?(wjohnston)
Created attachment 8600530 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/415

This is a mostly direct (rounding errors) move to what's in those SVG files. I'll upload an overlay image. Its close to desktops, but.. well desktop uses images right now and they've got aliasing built in. Its hard to compare. At this point, I think UX will have to hand refine, but figured I could give you a start.
Attachment #8600530 - Flags: review?(dhenein)
Created attachment 8600531 [details]
Overlay
(Assignee)

Comment 8

2 years ago
Created attachment 8602215 [details]
Sharp Curve Points

Hrm, seems to be closer by overlay, but still has some rough edges.
(Assignee)

Updated

2 years ago
Whiteboard: [qx]

Updated

2 years ago
tracking-fxios: --- → +
Closing this with WORKSFORME because :darrin closed the PR for this one with "While I know this is the curve we use elsewhere, I think the extra control points add a few sharp-ish corners. I think what we have in trunk is fine for now."
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
(Assignee)

Updated

2 years ago
tracking-fennec: + → ---
Attachment #8600530 - Flags: review?(dhenein)
You need to log in before you can comment on or make changes to this bug.