enable Service Worker Cache pref for non-release builds

RESOLVED FIXED in Firefox 39

Status

()

defect
RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

unspecified
mozilla39
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(2 attachments)

In order to support wider testing we are going to enable the SW prefs in non-release builds once the underlying feature is complete.  Now that bug 1110814 has landed Cache is ready to go.

The existing bug 1110144 will be used to track criteria for shipping Cache on release builds.
Do I need some kind of super review or something for this?
Attachment #8581934 - Flags: review?(ehsan)
Comment on attachment 8581934 [details] [diff] [review]
Flip dom.caches.enabled to true on non-release builds. r=ehsan

Review of attachment 8581934 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Ben Kelly [:bkelly] from comment #1)
> Do I need some kind of super review or something for this?

No, I think my review is enough.  A blog post however would be nice if you have the time.  Congrats on this first step towards shipping cache.  :-)
Attachment #8581934 - Flags: review?(ehsan) → review+
A try build showed enabling the pref broke a bunch of devtools tests.  The issue was that devtools iterates over global properties and tries to QI them to nsISupports.  CacheStorage currently does not have nsISupports in its interface map.  Oops!  This patch fixes that.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e46939958398
Attachment #8582105 - Flags: review?(ehsan)
(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #2)
> No, I think my review is enough.  A blog post however would be nice if you
> have the time.  Congrats on this first step towards shipping cache.  :-)

Thanks!  I'm working on the blog post, but I keep running into "one more thing" to do...
Attachment #8582105 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/5c2cd6a6cb35
https://hg.mozilla.org/mozilla-central/rev/3e26bf9400c8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.