1146557 - enable Service Worker Cache pref for non-release builds

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

In order to support wider testing we are going to enable the SW prefs in non-release builds once the underlying feature is complete.  Now that bug 1110814 has landed Cache is ready to go.

The existing bug 1110144 will be used to track criteria for shipping Cache on release builds.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Flip dom.caches.enabled to true on non-release builds. r=ehsan

Do I need some kind of super review or something for this?

Comment 2

[(no longer active)]

Comment on attachment 8581934 [details] [diff] [review]
Flip dom.caches.enabled to true on non-release builds. r=ehsan

Review of attachment 8581934 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Ben Kelly [:bkelly] from comment #1)
> Do I need some kind of super review or something for this?

No, I think my review is enough.  A blog post however would be nice if you have the time.  Congrats on this first step towards shipping cache.  :-)

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P1 Fix CacheStorage and Cache to QI to nsISupports correctly. r=ehsan

A try build showed enabling the pref broke a bunch of devtools tests.  The issue was that devtools iterates over global properties and tries to QI them to nsISupports.  CacheStorage currently does not have nsISupports in its interface map.  Oops!  This patch fixes that.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e46939958398

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #2)
> No, I think my review is enough.  A blog post however would be nice if you
> have the time.  Congrats on this first step towards shipping cache.  :-)

Thanks!  I'm working on the blog post, but I keep running into "one more thing" to do...

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e46939958398

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/5c2cd6a6cb35
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/3e26bf9400c8

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5c2cd6a6cb35
https://hg.mozilla.org/mozilla-central/rev/3e26bf9400c8