Closed Bug 1146568 Opened 5 years ago Closed 5 years ago

[e10s] browser_markupview_tag_edit_08.js causes unsafe CPOW usage warnings

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(e10sm8+, firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
e10s m8+ ---
firefox39 --- fixed

People

(Reporter: Kwan, Assigned: pbro)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1133577 +++

Mined from test logs

In browser/devtools/markupview/test/browser_markupview_tag_edit_08.js:

function* testCollapsedLongAttribute(inspector) {
  info("Try to modify the collapsed long attribute, making sure it expands.");

  info("Adding test attributes to the node");
  let onMutated = inspector.once("markupmutation");
  let node = getNode("#node24");
  node.setAttribute("class", ""); <- Causes CPOW warning
  node.setAttribute("data-long", LONG_ATTRIBUTE); <- Causes CPOW warning
  yield onMutated;

[...]
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
I'm going to wait until bug 1146566 is resolved before fixing this one because in bug 1146566, I'm loading the common devtools frame-script-utils.js frame-script which has a handy "devtools:test:setAttribute" message manager that we can use here.
Depends on: 1146566
/r/6025 - Bug 1146568 - Avoid unsafe CPOW usage warnings in browser_markupview_tag_edit_08.js; r=bgrins
/r/6027 - Bug 1146568 - Avoid unsafe CPOW usage in markupview tests, in assertAttributes helper; r=bgrins

Pull down these commits:

hg pull review -r 280a00192ce0d530594a1baed5ff58c763365029
Attachment #8583053 - Flags: review?(bgrinstead)
Comment on attachment 8583053 [details]
MozReview Request: bz://1146568/pbrosset

https://reviewboard.mozilla.org/r/6023/#review5013
Attachment #8583053 - Flags: review?(bgrinstead) → review+
https://hg.mozilla.org/mozilla-central/rev/c2ada63128e0
https://hg.mozilla.org/mozilla-central/rev/2d5f393a6f8d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Attachment #8583053 - Attachment is obsolete: true
Attachment #8619853 - Flags: review+
Attachment #8619854 - Flags: review+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.