1146568 - [e10s] browser_markupview_tag_edit_08.js causes unsafe CPOW usage warnings

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Ian Moody [:Kwan] (UTC+1)]

+++ This bug was initially created as a clone of Bug #1133577 +++

Mined from test logs

In browser/devtools/markupview/test/browser_markupview_tag_edit_08.js:

function* testCollapsedLongAttribute(inspector) {
  info("Try to modify the collapsed long attribute, making sure it expands.");

  info("Adding test attributes to the node");
  let onMutated = inspector.once("markupmutation");
  let node = getNode("#node24");
  node.setAttribute("class", ""); <- Causes CPOW warning
  node.setAttribute("data-long", LONG_ATTRIBUTE); <- Causes CPOW warning
  yield onMutated;

[...]

Comment 1

[Patrick Brosset <:pbro>]

I'm going to wait until bug 1146566 is resolved before fixing this one because in bug 1146566, I'm loading the common devtools frame-script-utils.js frame-script which has a handy "devtools:test:setAttribute" message manager that we can use here.

Comment 2

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: bz://1146568/pbrosset

/r/6025 - Bug 1146568 - Avoid unsafe CPOW usage warnings in browser_markupview_tag_edit_08.js; r=bgrins
/r/6027 - Bug 1146568 - Avoid unsafe CPOW usage in markupview tests, in assertAttributes helper; r=bgrins

Pull down these commits:

hg pull review -r 280a00192ce0d530594a1baed5ff58c763365029

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8583053 [details]
MozReview Request: bz://1146568/pbrosset

https://reviewboard.mozilla.org/r/6023/#review5013

Comment 4

[Patrick Brosset <:pbro>]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2eee17cb5fd6

https://hg.mozilla.org/integration/fx-team/rev/c2ada63128e0
https://hg.mozilla.org/integration/fx-team/rev/2d5f393a6f8d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c2ada63128e0
https://hg.mozilla.org/mozilla-central/rev/2d5f393a6f8d

Comment 7

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1146568 - Avoid unsafe CPOW usage warnings in browser_markupview_tag_edit_08.js; r=bgrins

Comment 8

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1146568 - Avoid unsafe CPOW usage in markupview tests, in assertAttributes helper; r=bgrins