1146611 - Allow opening url's with schemes we don't know about

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Wesley Johnston (:wesj)]

We currently just ignore any url schemes that we don't understand [1]. That list is really short. I think we should probably open any of them (if there's an app registered for it, but maybe show an alert/prompt before we do? That would be similar to what we do on Android (although we've opted not to prompt for things like mailto there, and we have more control over the dialer so we don't have to prompt for tel: either).

https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/BrowserViewController.swift#L739

Comment 1

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/303

Does this seem reasonable? I don't know why we'd ignore protocols...?

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The main reason to ignore protocols is as a security measure so that sites cannot transfer data to apps. Like x-some-app://foo?name=Stefan&personalData=LikesCheese .. I think if we prompt that is fine though?

See my note about a few special cases. I think we should mostly follow Safari.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8588171 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/303

I think this is good. Let's merge it and see how it works in practice.