Allow opening url's with schemes we don't know about

RESOLVED FIXED

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wesj, Unassigned)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(fennec+)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
We currently just ignore any url schemes that we don't understand [1]. That list is really short. I think we should probably open any of them (if there's an app registered for it, but maybe show an alert/prompt before we do? That would be similar to what we do on Android (although we've opted not to prompt for things like mailto there, and we have more control over the dialer so we don't have to prompt for tel: either).

https://github.com/mozilla/firefox-ios/blob/master/Client/Frontend/Browser/BrowserViewController.swift#L739
(Reporter)

Updated

3 years ago
tracking-fennec: --- → ?
tracking-fennec: ? → +
(Reporter)

Comment 1

3 years ago
Created attachment 8588171 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/303

Does this seem reasonable? I don't know why we'd ignore protocols...?
Attachment #8588171 - Flags: review?(jhugman)
(Reporter)

Updated

3 years ago
Attachment #8588171 - Flags: review?(jhugman) → review?(sarentz)
The main reason to ignore protocols is as a security measure so that sites cannot transfer data to apps. Like x-some-app://foo?name=Stefan&personalData=LikesCheese .. I think if we prompt that is fine though?

See my note about a few special cases. I think we should mostly follow Safari.
Comment on attachment 8588171 [details] [review]
PR https://github.com/mozilla/firefox-ios/pull/303

I think this is good. Let's merge it and see how it works in practice.
Attachment #8588171 - Flags: review?(sarentz) → review+
(Reporter)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.