1146626 - Async scrolling reftests fail when not using e10s

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Markus Stange [:mstange]]

Running
> mach reftest --setpref layers.async-pan-zoom.enabled=true layout/reftests/async-scrolling
on Mac results in many failures, because we're apparently not taking a new snapshot of the layer tree after we've adjusted the async scroll offsets.

I'm attaching a patch I wrote 5 months ago, and I've confirmed that it fixes it, but I don't know whether the "UpdateWholeCanvasForInvalidation" that it adds is in the right place.

Comment 1

[Markus Stange [:mstange]]

Attachment: patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Hopefully this will fix the windows async-scrolling reftest failures as well that I get when I do a try push with APZ enabled, e.g. https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc63db12dafb

Comment 3

[Markus Stange [:mstange]]

Attachment: patch

Still not sure if I've found the right place to make the change.

Comment 4

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/77f34f458d02

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/77f34f458d02