1146647 - [e10s] test-tabs-common.js causes unsafe CPOW usage warnings

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P4)

Description

[Ian Moody [:Kwan] (UTC+1)]

Mined from test logs

In addon-sdk/source/test/test-tabs-common.js:

exports.testAttachStyleToTab = function(assert, done) {
   let style = Style({
    source: "div { height: 100px; }",
    uri: fixtures.url("include-file.css")
  });

  tabs.open({
    url: "data:text/html;charset=utf-8,<div style='background: silver'>css test</div>",
    onReady: (tab) => {
      let xulTab = viewFor(tab);

      attach(style, tab)

      let { document } = getTabContentWindow(xulTab); <- Causes CPOW warning
      let div = document.querySelector("div"); <- Causes CPOW warning

      assert.equal(div.clientHeight, 100, <- Causes CPOW warning
        "Style.source properly attached to tab");

      assert.equal(div.offsetHeight, 120, <- Causes CPOW warning
        "Style.uri properly attached to tab");

      detach(style, tab);

      assert.notEqual(div.clientHeight, 100, <- Causes CPOW warning
        "Style.source properly detached from tab");

      assert.notEqual(div.offsetHeight, 120, <- Causes CPOW warning
        "Style.uri properly detached from tab");

      attach(style, xulTab);

      assert.equal(div.clientHeight, 100, <- Causes CPOW warning
        "Style.source properly attached to xul tab");

      assert.equal(div.offsetHeight, 120, <- Causes CPOW warning
        "Style.uri properly attached to xul tab");

      detach(style, tab);

      assert.notEqual(div.clientHeight, 100, <- Causes CPOW warning
        "Style.source properly detached from xul tab");

      assert.notEqual(div.offsetHeight, 120, <- Causes CPOW warning
        "Style.uri properly detached from xul tab");

      tab.close(done);
    }
  });
};

Comment 1

[Mike Conley (:mconley) (:⚙️)]

This is test only.

Comment 2

[:shell escalante]

we are going to check which tests pass - and then disable all that do not to detect breakages from this point on.  correcting the test suite issue across the board is a months long effort - that doesn't align with 2017 plans.

Comment 3

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562