Closed
Bug 1146651
Opened 9 years ago
Closed 9 years ago
Remove toggleResultSetResultStatusFilter because it appears to be unused.
Categories
(Tree Management :: Treeherder, defect, P4)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: KWierso, Assigned: jfrench)
Details
Attachments
(1 file)
As far as I can tell, https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/js/controllers/jobs.js#L197-L217 is completely unused now that the per-push filter buttons have been removed: https://github.com/mozilla/treeherder-ui/search?utf8=%E2%9C%93&q=toggleResultSetResultStatusFilter
Assignee | ||
Comment 1•9 years ago
|
||
I was wondering about this also.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Priority: -- → P4
Assignee | ||
Comment 2•9 years ago
|
||
Please see above PR for review and status.
Attachment #8585547 -
Flags: review?(cdawson)
Comment 3•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/cad3726dee196b5f227baf615afea4ba5fd4f106 Bug 1146651 - Remove legacy per-resultset filter code https://github.com/mozilla/treeherder-ui/commit/7c6dde6e75dc708adb614b03bd7851977d93b8c6 Merge pull request #444 from tojonmz/remove-resultset-filter Bug 1146651 - Remove legacy per-resultset filter code
Updated•9 years ago
|
Attachment #8585547 -
Flags: review?(cdawson) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Marking fixed and verified per above merge and current repo state.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Status: RESOLVED → VERIFIED
Comment 5•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/b6172fe4da25e756d22024dc66f118f293f9314a Bug 1146651 - Remove legacy per-resultset filter code https://github.com/mozilla/treeherder/commit/3e7b3e7ce3de2152a4c253280a787aa1f3d40d9e Merge pull request #444 from tojonmz/remove-resultset-filter Bug 1146651 - Remove legacy per-resultset filter code
You need to log in
before you can comment on or make changes to this bug.
Description
•