If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Tab tray collapsed tab representation should have bottom margin

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Right now, the bottom-most tab of the tabs tray touches the bottom.  It shouldn't.
(Assignee)

Updated

3 years ago
Assignee: nobody → nalexander
(Assignee)

Comment 1

3 years ago
Created attachment 8582091 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/258

Rubber stamp?
Attachment #8582091 - Flags: review?(bnicholson)
(Assignee)

Comment 2

3 years ago
Before: https://www.dropbox.com/s/yc73ui12pwrv8ay/Screenshot%202015-03-23%2017.37.28.png?dl=0

After: https://www.dropbox.com/s/yt30egy7y9cf4lc/Screenshot%202015-03-23%2017.29.32.png?dl=0

darrin can follow-up to tweak the vertical margins if need be.
Comment on attachment 8582091 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/258

LGTM
Attachment #8582091 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 4

3 years ago
https://github.com/mozilla/firefox-ios/commit/225d10a2b00ab86a0d88d4098d84af4d57f63763
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Depends on: 1147000
You need to log in before you can comment on or make changes to this bug.