1146727 - Add APZ info to about:support

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

I'd like to show a row in about:support under Graphics that details which events are being handled by APZ, and if there are any obscure prefs set that would cause those events to be handled synchronously.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1146727.patch

If APZ is not available at all, you'll see:
   Asynchronous Pan/Zoom	none

On Linux/Windows, you'll see:
   Asynchronous Pan/Zoom	scrolling enabled

If you have some crazy pref set, you'll see:
   Asynchronous Pan/Zoom	async scrolling disabled due to unsupported pref: mousewheel.default.delta_multiplier_x

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8582134 [details] [diff] [review]
bug1146727.patch

Review of attachment 8582134 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but I don't think I'm qualified to review. Leaving that to jrmuizel. One change I'd like to see in addition the comments below: override SupportsApzTouchInput to return true in widget/gonk/GfxInfo.cpp. I don't know if about:support is actually accessible on B2G but in case it is we should add that for correctness.

Also note that touch-based scrolling with APZ works now on windows if you set dom.w3c_touch_events.enabled to 1 or 2. However I guess unless we change the default value for that it makes sense to leave it as "unsupported".

::: toolkit/locales/en-US/chrome/global/aboutSupport.properties
@@ +95,5 @@
>  # or 'false')
>  multiProcessStatus = %1$S/%2$S (default: %3$S)
> +
> +asyncPanZoom = Asynchronous Pan/Zoom
> +wheelEnabled = scrolling enabled

s/scrolling/wheel input/

@@ +99,5 @@
> +wheelEnabled = scrolling enabled
> +touchEnabled = touch input enabled
> +
> +# LOCALIZATION NOTE %1 will be replaced with the key of a preference.
> +wheelProblem = async scrolling disabled due to unsupported pref: %S

s/scrolling/wheel input/

::: widget/nsIGfxInfo.idl
@@ +56,5 @@
>  
> +  const long APZ_FEATURE_WHEEL_INPUT = 1;
> +  const long APZ_FEATURE_TOUCH_INPUT = 2;
> +
> +  // Returns whether an APZ feature is supported and enabled, and if it is,

s/whether/true if/

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8582134 [details] [diff] [review]
bug1146727.patch

Review of attachment 8582134 [details] [diff] [review]:
-----------------------------------------------------------------

Did you consider using the GfxInfo::GetInfo/GfxInfoCollector infrastructure instead of exposing this directly.

See GetAzureBackendInfo for an example.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: v2

Refactor to use the GfxInfoCollector stuff, also includes kats's suggestions.

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

I didn't straight-up spew the collected keys for APZ since the formatted diagnostic info is a little more readable.

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/16be901108a8

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/16be901108a8