browser-sidebar logs lots of noise

RESOLVED FIXED in Firefox 39

Status

Firefox Graveyard
Reading List
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 39
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8582220 [details] [diff] [review]
0010-Bug-XXXXXXX-make-readinglist-sidebar-logs-less-noisy.patch

The logs for the sidebar end up in the readinglist "sync" logs (which seems fine) although they are a bit noisy.  This patch changes some log.debug calls to log.trace calls (.trace calls will *not* end up in these logs by default)
Attachment #8582220 - Flags: review?(florian)
Flags: qe-verify-
Flags: firefox-backlog+

Updated

3 years ago
Assignee: nobody → mhammond
Blocks: 1132074
Status: NEW → ASSIGNED
Iteration: --- → 39.3 - 30 Mar
Comment on attachment 8582220 [details] [diff] [review]
0010-Bug-XXXXXXX-make-readinglist-sidebar-logs-less-noisy.patch

Review of attachment 8582220 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/readinglist/sidebar.js
@@ +233,5 @@
>        log.error(`Unable to set selectedItem to invalid node ${node}`);
>        return;
>      }
>  
> +    log.trace(`Setting activeItem: ${node ? node.id : null}`);

While you are at it, please fix this to say "selectedItem" instead of "activeItem". I guess this was a copy/paste mistake initially.
Attachment #8582220 - Flags: review?(florian) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/b210e4342ee9
https://hg.mozilla.org/mozilla-central/rev/b210e4342ee9
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
https://hg.mozilla.org/releases/mozilla-aurora/rev/8f553b5d1768
status-firefox38: --- → fixed
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.