Closed
Bug 1146786
Opened 9 years ago
Closed 9 years ago
browser-sidebar logs lots of noise
Categories
(Firefox Graveyard :: Reading List, defect)
Firefox Graveyard
Reading List
Tracking
(firefox38 fixed, firefox39 fixed)
RESOLVED
FIXED
Firefox 39
People
(Reporter: markh, Assigned: markh)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.08 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
The logs for the sidebar end up in the readinglist "sync" logs (which seems fine) although they are a bit noisy. This patch changes some log.debug calls to log.trace calls (.trace calls will *not* end up in these logs by default)
Updated•9 years ago
|
Comment 1•9 years ago
|
||
Comment on attachment 8582220 [details] [diff] [review] 0010-Bug-XXXXXXX-make-readinglist-sidebar-logs-less-noisy.patch Review of attachment 8582220 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/components/readinglist/sidebar.js @@ +233,5 @@ > log.error(`Unable to set selectedItem to invalid node ${node}`); > return; > } > > + log.trace(`Setting activeItem: ${node ? node.id : null}`); While you are at it, please fix this to say "selectedItem" instead of "activeItem". I guess this was a copy/paste mistake initially.
Attachment #8582220 -
Flags: review?(florian) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b210e4342ee9
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b210e4342ee9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Comment 4•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/8f553b5d1768
status-firefox38:
--- → fixed
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•