Closed
Bug 1146799
Opened 9 years ago
Closed 9 years ago
B2G RIL: Pull out the TelephonyRequestQueue from RilWorker
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S10 (17apr)
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: gweng, Assigned: gweng)
References
Details
Attachments
(1 file)
10.53 KB,
patch
|
aknow
:
review+
|
Details | Diff | Splinter Review |
Following the Bug 1123201 I'll continue to split standalone functions to files.
Assignee | ||
Comment 1•9 years ago
|
||
Ahhh sorry cloning bug make dependencies as a mess. I now clean them.
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 2•9 years ago
|
||
Well, I have done my patch. However I don't know how to describe the class... Obviously it's a queue, but I can't think of any meaningful comment for it... Maybe reviewer could advise me after I passed the try server.
Comment 3•9 years ago
|
||
Just let you know... I am willing to review the patch when it is ready.
Assignee | ||
Comment 4•9 years ago
|
||
Thanks, I've set it in Comment.
Assignee | ||
Comment 5•9 years ago
|
||
The CI result is good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce657ebd74b5 So I set the review flag now.
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8587856 -
Flags: review?(szchen)
Comment 7•9 years ago
|
||
Comment on attachment 8587856 [details] [diff] [review] Patch rev1 Review of attachment 8587856 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thank you.
Attachment #8587856 -
Flags: review?(szchen) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/f47633f4ded2
Keywords: checkin-needed
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f47633f4ded2
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S10 (17apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•