Closed Bug 1146799 Opened 5 years ago Closed 5 years ago

B2G RIL: Pull out the TelephonyRequestQueue from RilWorker

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox40 fixed)

RESOLVED FIXED
2.2 S10 (17apr)
Tracking Status
firefox40 --- fixed

People

(Reporter: gweng, Assigned: gweng)

References

Details

Attachments

(1 file)

Following the Bug 1123201 I'll continue to split standalone functions to files.
Ahhh sorry cloning bug make dependencies as a mess. I now clean them.
Assignee: nobody → gweng
No longer blocks: 811754, 1113054
No longer depends on: 1123201, 1130938
Well, I have done my patch. However I don't know how to describe the class... Obviously it's a queue, but I can't think of any meaningful comment for it...

Maybe reviewer could advise me after I passed the try server.
Just let you know... I am willing to review the patch when it is ready.
Thanks, I've set it in Comment.
The CI result is good:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce657ebd74b5

So I set the review flag now.
Attached patch Patch rev1Splinter Review
Attachment #8587856 - Flags: review?(szchen)
Comment on attachment 8587856 [details] [diff] [review]
Patch rev1

Review of attachment 8587856 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  Thank you.
Attachment #8587856 - Flags: review?(szchen) → review+
https://hg.mozilla.org/mozilla-central/rev/f47633f4ded2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S10 (17apr)
Blocks: 811754
You need to log in before you can comment on or make changes to this bug.