1146809 - Context menu looks busted on Lollipop

Status: RESOLVED DUPLICATE of bug 1132747

(Firefox for Android Graveyard :: General, defect)

Description

[u421692]

Attachment: device-2015-03-24-101937.png

Steps to reproduce:
1. Long tap to trigger the context menu.

Expected result:
The context menu looks fine

Actual result:
The context menu is missing the horizontal divider lines, and the title of the context menu is black and changed font size.
PS: I'm not sure if this was intended, please see attached screenshots.

Regression window:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=8d5f10959b2c&tochange=ae4c0736cb3c

Bug 1138723 introduced this regression

Comment 1

[Wesley Johnston (:wesj)]

I think this is just material design. i.e. see the menu screenshots and discussions about dividers here:

http://www.google.com/design/spec/components/dialogs.html#dialogs-simple-dialogs

We really don't do much styling here (but we do set some options). The padding of the rows does look off to me.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Wesley Johnston (:wesj) from comment #1)
> I think this is just material design. i.e. see the menu screenshots and
> discussions about dividers here:
> 
> http://www.google.com/design/spec/components/dialogs.html#dialogs-simple-
> dialogs

Agreed.

> We really don't do much styling here (but we do set some options). The
> padding of the rows does look off to me.

Yes. The "Share" row looks like it has the wrong padding.

Comment 3

[u421692]

1. So, we should keep this bug open for a fix for the "Share" row padding?
2. Should the Firefox menu(three dots) be consistent with the context menu?
e.g. http://www.google.com/design/spec/components/menus.html

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Mihai Pop from comment #3)
> 1. So, we should keep this bug open for a fix for the "Share" row padding?

bug 1132747.

> 2. Should the Firefox menu(three dots) be consistent with the context menu?
> e.g. http://www.google.com/design/spec/components/menus.html

Anthony? (I personally have never liked those menu styles -_-)

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Mihai Pop from comment #3)
> 2. Should the Firefox menu(three dots) be consistent with the context menu?
> e.g. http://www.google.com/design/spec/components/menus.html

I'm open to this idea, but since we've heavily customized our 3-dot menu to be quite unique, and consistent across most versions of Android, I can forsee this having a lot of nuances. I've filed bug 1140169 in the interim. 

I think this change would be related to other bugs around Android L's new Toolbar specifications and maybe even related to "V2 toolbar improvements". But in the mean time, I think this specific bug would be a dupe for now (of bug 1132747).