1146842 - [Browser] No title and more info are not displayed in app permission page.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Alissa（leave from Mozilla）]

[1.Description]:
[Nexus 5 v2.2&v3.0][Flame v2.2&v3.0][Browser] As an user I want to play a video in full screen, in the app permission page, the title and more info button disappears.
Found at:6:53
see attachments:1.png & logcat2.txt

[2.Testing Steps]: 
1.Launch browser.
2.Go to www.youtube.com.
3.Play a video.
4.Tap fullscreen icon.

[3.Expected Result]: 
4.The title and more info button should be displayed in this page.

[4.Actual Result]: 
4.You can see the title and more info button are not displayed.

[5.Reproduction build]: 
Flame 3.0 [Affected]:
Build ID               20150323160205
Gaia Revision          8eac260ee81a8aca05770d18c5736536d44ee7a7
Gaia Date              2015-03-23 02:41:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/bc85c479668a
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150323.193421
Firmware Date          Mon Mar 23 19:34:34 EDT 2015
Bootloader             L1TC000118D0

Flame 2.2[Affected]:
Build ID               20150323162503
Gaia Revision          e54c4ed1cc188f70ddf1156534d364005dc45490
Gaia Date              2015-03-23 19:09:26
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/7ba1778d237b
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150323.200543
Firmware Date          Mon Mar 23 20:05:54 EDT 2015
Bootloader             L1TC000118D0

N5_2.2[Affected]:
Build ID               20150323002504
Gaia Revision          7f367fc98ffdd183f21d2cdfe20556ab877ece34
Gaia Date              2015-03-23 05:35:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3ea0eaeda353
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150323.040519
Firmware Date          Mon Mar 23 04:05:35 EDT 2015
Bootloader             HHZ12d

Nexus 5 3.0[Affected]:
Build ID               20150323160205
Gaia Revision          8eac260ee81a8aca05770d18c5736536d44ee7a7
Gaia Date              2015-03-23 02:41:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/bc85c479668a
Gecko Version          39.0a1
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150323.193411
Firmware Date          Mon Mar 23 19:34:28 EDT 2015
Bootloader             HHZ12d
[6.Reproduction Frequency]: 
occasionally Recurrence,19/20

[7.TCID]: 
Free Test

Comment 1

[Alissa（leave from Mozilla）]

Attachment: logcat2.txt

Comment 2

[Alissa（leave from Mozilla）]

Attachment: 1.png

Comment 3

[Gregor Wagner [:gwagner]]

Francis?

Comment 4

[Francis Djabri [:djabber]]

In general, we should still show the status indicators through the confirmation dialog scrim. Eric, could you confirm the exact treatment here? Thanks.

Comment 5

[Eric Pang [:epang] UX]

(In reply to Francis Djabri [:djabber] from comment #4)
> In general, we should still show the status indicators through the
> confirmation dialog scrim. Eric, could you confirm the exact treatment here?
> Thanks.

We should do the same thing I posted to bug 1111997 in comment 14
The icons should be white at 15% opacity.  This will they look muted but the information is still there for the user.

Let me know if there are any questions, thanks!

Comment 6

[Candice Serran (:cserran)]

Etienne or Alive, could either of you take a look at this bug please?

Comment 7

[Gregor Wagner [:gwagner]]

How about 2.1?

Comment 8

[Yeojin Chung [:YeojinC]]

This issue does NOT reproduce on Flame 2.1.

Result: On the fullscreen permission dialog, "More info..." button is displayed. However, nothing happens when the user taps on "More info...".

Environmental Variables:
Device: Flame 2.1
Build ID: 20150325153710
Gaia: 6f39e4e876152de1dcdcc0e7656197f22f105e4b
Gecko: e00ae73d67a2
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 9

[Yeojin Chung [:YeojinC]]

Attachment: 2.1.png

Comment 10

[KTucker [:KTucker][Inactive 3/4/2016]]

B2G Inbound regression window:

Last Working
Device: Flame 2.2
BuildID: 20150108184400
Gaia: 5f0dd37917c4a6d8fa8724715d4d3797419f9013
Gecko: 0c39bc01f634
Version: 37.0a1 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

First Broken
Device: Flame 2.2
BuildID: 20150108190812
Gaia: e375e8ba954620493aaa77fff237609b227b7b7e
Gecko: 851db86c6b3e
Version: 37.0a1 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 5f0dd37917c4a6d8fa8724715d4d3797419f9013
Gecko: 851db86c6b3e

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: e375e8ba954620493aaa77fff237609b227b7b7e
Gecko: 0c39bc01f634

https://github.com/mozilla-b2g/gaia/compare/5f0dd37917c4a6d8fa8724715d4d3797419f9013...e375e8ba954620493aaa77fff23760

This might have been caused by bug 1118891

Comment 11

[Alissa（leave from Mozilla）]

(In reply to Yeojin Chung [:YeojinC] from comment #8)
> This issue does NOT reproduce on Flame 2.1.
> 
> Result: On the fullscreen permission dialog, "More info..." button is
> displayed. However, nothing happens when the user taps on "More info...".
> 
> Environmental Variables:
> Device: Flame 2.1
> Build ID: 20150325153710
> Gaia: 6f39e4e876152de1dcdcc0e7656197f22f105e4b
> Gecko: e00ae73d67a2
> Version: 34.0 (2.1)
> Firmware Version: v18D-1
> User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Hello, Yeojin Chung 
Could you help to check flame 2.1 agian, the results you descripted is not always appear in my testing, please see bug 1145537(https://bugzilla.mozilla.org/show_bug.cgi?id=1145537), so I think this issue is also exist on flame 2.1.

Comment 12

[Yeojin Chung [:YeojinC]]

I checked on the latest Flame 2.1, and I got the same result. In 30 attempts, it always showed "More info..." button (https://bugzilla.mozilla.org/attachment.cgi?id=8581409), and it was not responsive. 

Environmental Variables:
Device: Flame 2.1
BuildID: 20150326151146
Gaia: 6f39e4e876152de1dcdcc0e7656197f22f105e4b
Gecko: f4d7c0e7292e
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 13

[Gregor Wagner [:gwagner]]

Kevin, seems like 1118891 broke it.

Comment 14

[Kevin Grandon :kgrandon]

It seems unlikely that bug 1118891 broke this, but possibly it's surfacing another bug in the system? I will take a look.

Comment 15

[Kevin Grandon :kgrandon]

I confirmed by backing out bug 1118891 that it was not the cause of this. 

I don't think it needs to be a blocker as the "more info" link was present on v2.1, but non-functioning. My guess is that the appearance of this link in 2.1 is a regression, it does not appear in 2.0.

Adding a needinfo on Francis - are we supposed to have a title and "more info" link on this app permission page, who would know?

Comment 16

[Gregor Wagner [:gwagner]]

Not a regression since link was present but non-functioning.

Comment 17

[Francis Djabri [:djabber]]

The most definitive guide I can find to this is the App permissions spec that Omega wrote, although it doesn't cover this dialog specifically:
https://mozilla.box.com/s/h2zrxi6duv92a5xg11qf2us6rhjetseq

FWIW, removing the More info link seems like a huge improvement :) But I agree having the title makes sense. 

Omega, do you have any comments on the design of this dialog?

Comment 18

[Omega Feng [:Omega] [:馮於懋]]

I think it's not an App Permission but a Website Permission, so the dialog should look like:

Website Permission
---------------------
http://m.youtube.com is now fullscreen.

[Don't Allow] [Allow]

So the only thing we should do is to add the title "Website Permission in the dialog.

Comment 19

[BMO Automation]

Firefox OS is not being worked on