1146850 - When bookmarking a page, adjust the AccessibilityLabel to the current status of the bookmarking

Status: RESOLVED WORKSFORME

(Firefox for iOS :: Browser, defect)

Description

[Marco Zehe (:MarcoZ)]

When bookmarking a page, VoiceOver does not get told the new status of the bookmarked page. The label stays at "Bookmark", meanig this gives the instruction to bookmark the page. If a page is bookmarked, I assume the button looks different to indicate that fact. This also needs to be communicated to VoiceOver users via a different AccessibilityLabel for the button. Labels could be "Remove Bookmark" or "Bookmarked".

Comment 1

[Aaron Train [:aaronmt]]

Also useful for toolbar bookmarking UITests

Comment 2

[Boris Dušek]

Currently it is announcing bookmarking by saying or not saying "Selected" (i.e. the UIAccessibilityTraitSelected), so it announces either "Selected, Bookmark", or "Bookmark".

An example of a similar element is in iBooks, again with bookmark. The accessibility label there alternates between "Add Bookmark" and "Remove Bookmark". In Photos.app, favorites uses the trait as we currently do, i.e. announces "Selected, Favorites" or "Favorites", so Apple is not consistent in how to handle this type of element.

Comment 3

[Marco Zehe (:MarcoZ)]

Not for me, and not in build 6 (the "official" one. In that build, the bookmark button even got a label of "Share", which is total bogus. And I don't see a selected trait being set or removed.

Comment 4

[Boris Dušek]

I was testing with master, which probably explains the difference. v7 got tagged in the repository recently, do you have access to that build so that could you test with that?

Comment 5

[Marco Zehe (:MarcoZ)]

Fixed in build 7.