Closed Bug 1146877 Opened 9 years ago Closed 9 years ago

Intermittent test_ftu_skip_tour_desktopb2g.py TestFtu.test_ftu_skip_tour_for_desktop | TimeoutException: TimeoutException: Timed out after 10.0 seconds

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: RyanVM, Assigned: martijn.martijn, NeedInfo)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

[gaia] mwargers:ftu_skip_fix > mozilla-b2g:master
46 bytes, text/x-github-pull-request
martijn.martijn
: review+
Details | Review 
16:27:10 INFO - TEST-START | test_ftu_skip_tour_desktopb2g.py TestFtu.test_ftu_skip_tour_for_desktop
16:27:57 ERROR - TEST-UNEXPECTED-ERROR | test_ftu_skip_tour_desktopb2g.py TestFtu.test_ftu_skip_tour_for_desktop | TimeoutException: TimeoutException: Timed out after 10.0 seconds
16:27:57 INFO - Traceback (most recent call last):
16:27:57 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 296, in run
16:27:57 INFO - testMethod()
16:27:57 INFO - File "/builds/slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/ftu/test_ftu_skip_tour_desktopb2g.py", line 53, in test_ftu_skip_tour_for_desktop
16:27:57 INFO - self.ftu.tap_next_to_finish_section()
16:27:57 INFO - File "/builds/slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/apps/ftu/app.py", line 355, in tap_next_to_finish_section
16:27:57 INFO - *self._section_finish_locator))))
16:27:57 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette_driver/wait.py", line 143, in until
16:27:57 INFO - cause=last_exc)
16:27:57 INFO - TEST-INFO took 46734ms
Comment on attachment 8582424 [details] [review]
[gaia] mwargers:ftu_skip_fix > mozilla-b2g:master

The time.sleep call was necessary for an intermittent failure that I was seeing locally on my machine.

The wait for is_keyboard_displayed part is to fix this intermittent failure.
Attachment #8582424 - Flags: review?(jlorenzo)
Attachment #8582424 - Flags: review?(gmealer)
Assignee: nobody → martijn.martijn
Comment on attachment 8582424 [details] [review]
[gaia] mwargers:ftu_skip_fix > mozilla-b2g:master

I asked that the import be moved to top of file rather than being inline. Otherwise, looks fine, though with the arbitrary sleep make sure you wait for all try server results to resolve.

r+ with the import move, no re-review necessary from me.
Attachment #8582424 - Flags: review?(gmealer) → review+
Comment on attachment 8582424 [details] [review]
[gaia] mwargers:ftu_skip_fix > mozilla-b2g:master

I guess we could have a better explanation of why this sleep is here. A first thing that comes to my mind is that it's a race condition in the product. Like: the button is correctly displayed, enabled, and we actually click on it but the event is not correctly propagated in gaia.

However, as we recently brought back this test on b2g desktop (bug 1145665) and we're dropping the Gip suite, I think this quick fix is currently good enough.
Attachment #8582424 - Flags: review?(jlorenzo) → review+
Comment on attachment 8582493 [details] [review]
[gaia] mwargers:ftu_skip_fix > mozilla-b2g:master

r+ from gmealer and jlorenzo.
Attachment #8582493 - Flags: review+
Attachment #8582424 - Attachment is obsolete: true
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #6)
> Comment on attachment 8582424 [details] [review]
> [gaia] mwargers:ftu_skip_fix > mozilla-b2g:master
> 
> I guess we could have a better explanation of why this sleep is here. A
> first thing that comes to my mind is that it's a race condition in the
> product. Like: the button is correctly displayed, enabled, and we actually
> click on it but the event is not correctly propagated in gaia.

Well, that wouldn't explain why the event is not correctly propagated. My guess is that when the button gets enabled, some event listeners are added that make the button function. On b2g desktop, it seems to be possible that the button is pressed before those event listeners are added. But this is only a guess.
Finally got a try run that gave results (all green), so adding checkin-needed keyword.
Keywords: checkin-needed
http://docs.taskcluster.net/tools/task-graph-inspector/#SQpa-oDGQYCfeXHMONJ4rw

The pull request failed to pass integration tests. It could not be landed, please try again.
(In reply to Autolander from comment #17)
> http://docs.taskcluster.net/tools/task-graph-inspector/#SQpa-
> oDGQYCfeXHMONJ4rw
> 
> The pull request failed to pass integration tests. It could not be landed,
> please try again.

James, what does this mean?
I did a try run on treeherder and the tests all passed there.
With this taskcluster thing, I see a failure in test_browser_play_video.py in Gaia ui tests 4, but I don't get that with this patch applied and testing locally.
Flags: needinfo?(jlal)
(In reply to Martijn Wargers [:mwargers] (QA) from comment #18)
> (In reply to Autolander from comment #17)
> > http://docs.taskcluster.net/tools/task-graph-inspector/#SQpa-
> > oDGQYCfeXHMONJ4rw
> > 
> > The pull request failed to pass integration tests. It could not be landed,
> > please try again.
> 
> James, what does this mean?
> I did a try run on treeherder and the tests all passed there.
> With this taskcluster thing, I see a failure in test_browser_play_video.py
> in Gaia ui tests 4, but I don't get that with this patch applied and testing
> locally.

I understand this could be bug 1147176.
I've merged it myself now, there is indication that the merge test runs are not reliable (for instance, in bug 1139083 it is mentioned).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: