Prepare Bluetooth backends for bug 1146355

RESOLVED FIXED in Firefox 39

Status

Firefox OS
Bluetooth
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

unspecified
2.2 S9 (3apr)
All
Gonk (Firefox OS)

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(4 attachments)

Some small cleanups in the Bluetooth's backend code can simplify the merger of both Bluetooth implementations.
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → All
Created attachment 8582429 [details] [diff] [review]
[01] Bug 1146923: Merge |CONVERT| macros of Bluetooth backends
Attachment #8582429 - Flags: review?(btian)
Created attachment 8582431 [details] [diff] [review]
[02] Bug 1146923: Rename |BluetoothDeviceType| to |BluetoothTypeOfDevice|
Attachment #8582431 - Flags: review?(btian)
Created attachment 8582434 [details] [diff] [review]
[03] Bug 1146923: Rename |BluetoothSspPairingVariant| to |BluetoothSspVariant|
Attachment #8582434 - Flags: review?(btian)
Created attachment 8582436 [details] [diff] [review]
[04] Bug 1146923: Pass SSP variant as enum instead of string
Attachment #8582436 - Flags: review?(btian)

Comment 5

3 years ago
Comment on attachment 8582429 [details] [diff] [review]
[01] Bug 1146923: Merge |CONVERT| macros of Bluetooth backends

Review of attachment 8582429 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8582429 - Flags: review?(btian) → review+

Comment 6

3 years ago
Comment on attachment 8582431 [details] [diff] [review]
[02] Bug 1146923: Rename |BluetoothDeviceType| to |BluetoothTypeOfDevice|

Review of attachment 8582431 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8582431 - Flags: review?(btian) → review+

Comment 7

3 years ago
Comment on attachment 8582434 [details] [diff] [review]
[03] Bug 1146923: Rename |BluetoothSspPairingVariant| to |BluetoothSspVariant|

Review of attachment 8582434 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8582434 - Flags: review?(btian) → review+

Comment 8

3 years ago
Comment on attachment 8582436 [details] [diff] [review]
[04] Bug 1146923: Pass SSP variant as enum instead of string

Review of attachment 8582436 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8582436 - Flags: review?(btian) → review+
https://hg.mozilla.org/mozilla-central/rev/351037d50b6a
https://hg.mozilla.org/mozilla-central/rev/648003ae99f0
https://hg.mozilla.org/mozilla-central/rev/ad9d80aa4f2c
https://hg.mozilla.org/mozilla-central/rev/e81e1da40a9c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S9 (3apr)
this bug was backed out on b2g-inbound:
http://hg.mozilla.org/integration/b2g-inbound/rev/8f132c4bba3d

I don't see reference to that in here? is this open or closed?
Flags: needinfo?(tzimmermann)
The backout mentioned in comment 11. The patches have then been fixed and landed again. The bug should now be RESOLVED/FIXED.
Flags: needinfo?(tzimmermann)
'is mentioned'
thanks, apologies for not finding comment 11 in there.
You need to log in before you can comment on or make changes to this bug.