Closed Bug 1146923 Opened 5 years ago Closed 5 years ago

Prepare Bluetooth backends for bug 1146355

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox39 fixed)

RESOLVED FIXED
2.2 S9 (3apr)
Tracking Status
firefox39 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(4 files)

Some small cleanups in the Bluetooth's backend code can simplify the merger of both Bluetooth implementations.
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → All
Comment on attachment 8582429 [details] [diff] [review]
[01] Bug 1146923: Merge |CONVERT| macros of Bluetooth backends

Review of attachment 8582429 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8582429 - Flags: review?(btian) → review+
Comment on attachment 8582431 [details] [diff] [review]
[02] Bug 1146923: Rename |BluetoothDeviceType| to |BluetoothTypeOfDevice|

Review of attachment 8582431 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8582431 - Flags: review?(btian) → review+
Comment on attachment 8582434 [details] [diff] [review]
[03] Bug 1146923: Rename |BluetoothSspPairingVariant| to |BluetoothSspVariant|

Review of attachment 8582434 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8582434 - Flags: review?(btian) → review+
Comment on attachment 8582436 [details] [diff] [review]
[04] Bug 1146923: Pass SSP variant as enum instead of string

Review of attachment 8582436 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8582436 - Flags: review?(btian) → review+
this bug was backed out on b2g-inbound:
http://hg.mozilla.org/integration/b2g-inbound/rev/8f132c4bba3d

I don't see reference to that in here? is this open or closed?
Flags: needinfo?(tzimmermann)
The backout mentioned in comment 11. The patches have then been fixed and landed again. The bug should now be RESOLVED/FIXED.
Flags: needinfo?(tzimmermann)
'is mentioned'
thanks, apologies for not finding comment 11 in there.
You need to log in before you can comment on or make changes to this bug.