Closed
Bug 1147000
Opened 10 years ago
Closed 10 years ago
No panel selected at startup
Categories
(Firefox for iOS :: Home screen, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bnicholson, Assigned: bnicholson)
References
Details
Attachments
(1 file)
Looks like a regression from the index optimization in bug 1146708, where we don't select a panel if the selected index hasn't changed. Problem is, the selected index is initially 0, so the initial load bails and nothing is selected.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8582510 -
Flags: review?(nalexander)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8582510 [details] [review]
Pull request
Land this if you must, but I'd prefer a proper solution. Maybe make index Int? and do the right thing on nil?
Attachment #8582510 -
Flags: review?(nalexander) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8582510 [details] [review]
Pull request
Fair enough, updated with a not lazy solution :D
Attachment #8582510 -
Flags: review+ → review?(nalexander)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8582510 [details] [review]
Pull request
lgtm.
Attachment #8582510 -
Flags: review?(nalexander) → review+
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•