Rename attachProcess to getProcess

RESOLVED FIXED in Firefox 39

Status

defect
RESOLVED FIXED
4 years ago
Last year

People

(Reporter: jryans, Assigned: jryans)

Tracking

unspecified
Firefox 39
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

4 years ago
In bug 1134180, we agree that |attachProcess| should be |getProcess| to match the new |getTab|, and also because attach is a separate concept.
Assignee

Updated

4 years ago
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Assignee

Comment 2

4 years ago
/r/5989 - Bug 1147042 - Rename attachProcess to getProcess. r=ochameau

Pull down this commit:

hg pull review -r 57bec922ed72e3bd4ac4afd885c6ee78c14dd632
Attachment #8582623 - Flags: review?(poirot.alex)
Comment on attachment 8582623 [details]
MozReview Request: bz://1147042/jryans

Thanks!

There is a failure on try, but that looks unrelated...
Attachment #8582623 - Flags: review?(poirot.alex) → review+
Assignee

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/f94c011d8270
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f94c011d8270
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Doesn't this affect Thunderbird, Fennec, WebRT and others?
It shouldn't as soon as they are setting DebuggerServer.allowChromeProcess=true.

Thunderbird is based on mozilla - central, right ?
We plan to uplift this patch in order to ensure all released version uses get process. So if Thunderbird is using its own branches, we would have to uplift also on TB branches.

The only thing to know is that it will break main process debugging when using a older Firefox version against a newer Firefox/Thunderbird 39/40 version. But it is going to work if you both uses the latest.
Assignee

Updated

4 years ago
Blocks: 1150577
Assignee

Comment 9

4 years ago
Attachment #8582623 - Attachment is obsolete: true
Attachment #8619862 - Flags: review+

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.