39 bytes, text/x-review-board-request
In bug 1134180, we agree that |attachProcess| should be |getProcess| to match the new |getTab|, and also because attach is a separate concept.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
/r/5989 - Bug 1147042 - Rename attachProcess to getProcess. r=ochameau Pull down this commit: hg pull review -r 57bec922ed72e3bd4ac4afd885c6ee78c14dd632
Attachment #8582623 - Flags: review?(poirot.alex)
Comment on attachment 8582623 [details] MozReview Request: bz://1147042/jryans Thanks! There is a failure on try, but that looks unrelated...
Attachment #8582623 - Flags: review?(poirot.alex) → review+
Let's try xpcshell one more time... https://treeherder.mozilla.org/#/jobs?repo=try&revision=359f29249817
Doesn't this affect Thunderbird, Fennec, WebRT and others?
It shouldn't as soon as they are setting DebuggerServer.allowChromeProcess=true. Thunderbird is based on mozilla - central, right ? We plan to uplift this patch in order to ensure all released version uses get process. So if Thunderbird is using its own branches, we would have to uplift also on TB branches. The only thing to know is that it will break main process debugging when using a older Firefox version against a newer Firefox/Thunderbird 39/40 version. But it is going to work if you both uses the latest.
You need to log in before you can comment on or make changes to this bug.