1147042 - Rename attachProcess to getProcess

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In bug 1134180, we agree that |attachProcess| should be |getProcess| to match the new |getTab|, and also because attach is a separate concept.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a46feb7a3aa

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: bz://1147042/jryans

/r/5989 - Bug 1147042 - Rename attachProcess to getProcess. r=ochameau

Pull down this commit:

hg pull review -r 57bec922ed72e3bd4ac4afd885c6ee78c14dd632

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8582623 [details]
MozReview Request: bz://1147042/jryans

Thanks!

There is a failure on try, but that looks unrelated...

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Let's try xpcshell one more time...

https://treeherder.mozilla.org/#/jobs?repo=try&revision=359f29249817

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/f94c011d8270

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f94c011d8270

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Doesn't this affect Thunderbird, Fennec, WebRT and others?

Comment 8

[Alexandre Poirot [:ochameau]]

It shouldn't as soon as they are setting DebuggerServer.allowChromeProcess=true.

Thunderbird is based on mozilla - central, right ?
We plan to uplift this patch in order to ensure all released version uses get process. So if Thunderbird is using its own branches, we would have to uplift also on TB branches.

The only thing to know is that it will break main process debugging when using a older Firefox version against a newer Firefox/Thunderbird 39/40 version. But it is going to work if you both uses the latest.

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1147042 - Rename attachProcess to getProcess. r=ochameau