1147046 - Tools under layout use gBrowser.contentDocument and/or gBrowser.contentWindow, which don't exist in e10s browsers

Status: RESOLVED WONTFIX

(Core :: Layout, defect, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1144149 will add contentDocumentAsCPOW and contentWindowAsCPOW shortcuts to gBrowser.

When that happens, layout/tools/layout-debug/ui/content/layoutdebug.js and layout/tools/recording/recording.js should be updated to use those instead.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Are these tools that we still use Bas? If so, how important is that we make them work in e10s?

Comment 2

[Bas Schouten (:bas.schouten)]

(In reply to Bill McCloskey (:billm) from comment #1)
> Are these tools that we still use Bas? If so, how important is that we make
> them work in e10s?

I don't know layout-debug. As for recording I'd say for now it's not too important as its result shouldn't differ too much with, or without e10s. So if it is to be used for diagnostic purposes e10s could be switched off. In general the tool is not of critical importance anyway.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I use layout-debug occasionally; I suspect others like dholbert and mats and other people who work on layout may as well.  The things it does can also be done from gdb (although it's harder to get the right object to start from) or by inserting calls to the various dumping functions in the code, but that's slower.

Comment 4

[Seth Fowler [:seth] [:s2h]]

If layout-debug is the Layout Debugger, then I definitely use it.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

The good news is that I'm pretty sure these tools will end up getting the add-on shims, so they'll probably continue to work for at least a while, even though unsafe CPOWs in browser code have been outlawed.

Comment 6

[Andrew McCreight [:mccr8]]

CPOWs have been removed.