1147052 - Tests under toolkit use gBrowser.contentDocument and/or gBrowser.contentWindow, which don't exist in e10s browsers

Status: RESOLVED WONTFIX

(Toolkit :: General, defect, P5)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1144149 will add contentDocumentAsCPOW and contentWindowAsCPOW shortcuts to gBrowser.

When that happens, tests under toolkit should be updated to use that instead.

Note that since these are tests, Mochitest will take advantage of the add-on shims, and will get gBrowser.contentWindow and gBrowser.contentDocument as expected. We should, however, migrate over eventually before we start dialing back the shims.

Tests using gBrowser.contentDocument and/or gBrowser.contentWindow under toolkit/:

toolkit/components/places/tests/browser/browser_bug680727.js
toolkit/components/viewsource/test/browser/browser_bug464222.js
toolkit/components/viewsource/test/browser/browser_bug699356.js
toolkit/components/viewsource/test/browser/browser_bug713810.js
toolkit/components/viewsource/test/browser/browser_contextmenu.js
toolkit/components/viewsource/test/browser/browser_gotoline.js
toolkit/components/viewsource/test/browser/browser_viewsourceprefs.js
toolkit/components/viewsource/test/browser/browser_viewsourceprefs_nonhtml.js
toolkit/content/tests/browser/browser.ini
toolkit/content/tests/browser/browser_autoscroll_disabled.js
toolkit/content/tests/browser/browser_bug295977_autoscroll_overflow.js
toolkit/content/tests/browser/browser_default_image_filename.js
toolkit/content/tests/browser/browser_input_file_tooltips.js
toolkit/content/tests/browser/browser_keyevents_during_autoscrolling.js
toolkit/content/tests/browser/browser_save_resend_postdata.js
toolkit/content/tests/chrome/bug263683_window.xul
toolkit/content/tests/chrome/bug304188_window.xul
toolkit/content/tests/chrome/bug360437_window.xul
toolkit/content/tests/chrome/bug409624_window.xul
toolkit/content/tests/chrome/bug451286_window.xul
toolkit/content/tests/chrome/bug451540_window.xul
toolkit/content/tests/chrome/findbar_events_window.xul
toolkit/content/tests/chrome/findbar_window.xul
toolkit/mozapps/extensions/test/browser/browser_bug562797.js
toolkit/mozapps/extensions/test/xpinstall/browser_badargs.js
toolkit/mozapps/extensions/test/xpinstall/browser_badargs2.js
toolkit/mozapps/extensions/test/xpinstall/browser_bug638292.js
toolkit/mozapps/extensions/test/xpinstall/browser_corrupt.js
toolkit/mozapps/extensions/test/xpinstall/browser_enabled.js
toolkit/mozapps/extensions/test/xpinstall/browser_enabled2.js
toolkit/mozapps/extensions/test/xpinstall/browser_enabled3.js
toolkit/mozapps/extensions/test/xpinstall/browser_localfile2.js
toolkit/mozapps/extensions/test/xpinstall/browser_relative.js
toolkit/mozapps/extensions/test/xpinstall/browser_trigger_redirect.js
toolkit/mozapps/extensions/test/xpinstall/browser_unsigned_trigger.js
toolkit/mozapps/extensions/test/xpinstall/browser_whitelist.js
toolkit/mozapps/extensions/test/xpinstall/head.js

Comment 1

[Dave Townsend [:mossop]]

Isn't the long-term plan to drop contentWindowAsCPOW etc. too? I.e. shouldn't we be migrating these tests away from direct window access entirely rather than switching them from one deprecated API to another?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

(In reply to Dave Townsend [:mossop] from comment #1)
> Isn't the long-term plan to drop contentWindowAsCPOW etc. too? I.e.
> shouldn't we be migrating these tests away from direct window access
> entirely rather than switching them from one deprecated API to another?

I guess it's a matter of understanding how difficult that'd be for these tests (which I haven't looked at closely, tbh). If we can switch them over to using messages, so much the better!

Comment 3

[Andrew McCreight [:mccr8]]

CPOWs have been removed.