1147168 - IPC Proxy for Selection

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

Comment 1

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8582719 [details] [diff] [review]
v1

>+  nsAutoTArray<uint64_t, 10> itemIDs;
>+  unused << mDoc->SendSelectedItems(mID, &itemIDs);
>+  aSelectedItems->SetCapacity(itemIDs.Length());
>+  for (uint32_t i = 0; i < itemIDs.Length(); ++i) {

size_t?

>+    aSelectedItems->AppendElement(mDoc->GetAccessible(itemIDs[i]));

I wonder if it makes sense to add a function to do this array conversion.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Yeah, I think I should add a helper for the array conversion and then convert the existing
cases to use it.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: size_t

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cff4597a0bf8

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cff4597a0bf8