Closed Bug 1147168 Opened 5 years ago Closed 5 years ago

IPC Proxy for Selection

Categories

(Core :: Disability Access APIs, defect)

36 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(2 files)

Attached patch v1Splinter Review
No description provided.
Attachment #8582719 - Flags: review?(tbsaunde+mozbugs)
Comment on attachment 8582719 [details] [diff] [review]
v1

>+  nsAutoTArray<uint64_t, 10> itemIDs;
>+  unused << mDoc->SendSelectedItems(mID, &itemIDs);
>+  aSelectedItems->SetCapacity(itemIDs.Length());
>+  for (uint32_t i = 0; i < itemIDs.Length(); ++i) {

size_t?

>+    aSelectedItems->AppendElement(mDoc->GetAccessible(itemIDs[i]));

I wonder if it makes sense to add a function to do this array conversion.
Attachment #8582719 - Flags: review?(tbsaunde+mozbugs) → review+
Yeah, I think I should add a helper for the array conversion and then convert the existing
cases to use it.
Attached patch size_tSplinter Review
https://hg.mozilla.org/mozilla-central/rev/cff4597a0bf8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.