[music] Embedded FLAC album art larger than ~64KB doesn't work

RESOLVED FIXED

Status

Firefox OS
Gaia::Music
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: squib, Assigned: squib)

Tracking

unspecified
x86_64
Linux
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Looks like we forgot to add the sliceOffset to the position where the embedded art starts. This wasn't causing a test failure because our files were small enough to fit inside the initial read via BlobView.

I could add tests, but I'm not sure it's worth it in this case...

Comment 1

3 years ago
Created attachment 8582753 [details] [review]
[gaia] jimporter:music-flac-art > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8582753 - Flags: review?(hub)
Comment on attachment 8582753 [details] [review]
[gaia] jimporter:music-flac-art > mozilla-b2g:master

Looks good to me.
Attachment #8582753 - Flags: review?(hub) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Comment 3

3 years ago
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/8776c2c0308dd1d47eddcdbd3214f746687809c5

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.