Closed Bug 1147223 Opened 5 years ago Closed 5 years ago

Fix wheel events not applying root scroll delta overrides

Categories

(Core :: Panning and Zooming, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

I messed up in bug 1141728. Windows has a default mousewheel.system_scroll_override_on_root_content.enabled value of true, with a delta multiplier of 2.0. Wheel events by default aren't going through APZ on Windows.

Easiest solution is to just honor the pref. This patch won't honor the extra gunk in nsWindow::OverrideSystemMouseScrollSpeed, but currently e10s doesn't honor it anyway since it goes through PuppetWidget.

I'm cleaning up the about:support detection of bad prefs after discovering this, since using HasUserPref() doesn't necessarily catch bad settings.
Attached patch fixSplinter Review
Attachment #8582778 - Flags: review?(bugmail.mozilla)
Comment on attachment 8582778 [details] [diff] [review]
fix

Review of attachment 8582778 [details] [diff] [review]:
-----------------------------------------------------------------

I'd like to see this split into two patches for landing - first one does the APZ changes and removes the override_on_root_content pref from the gfxPlatform list; second one does the rest of the gfxPlatform changes.

::: gfx/thebes/gfxPrefs.h
@@ +338,5 @@
> +  DECL_GFX_PREF(Live, "mousewheel.system_scroll_override_on_root_content.enabled",
> +                                                               MouseWheelHasRootScrollDeltaOverride, bool, false);
> +  DECL_GFX_PREF(Live, "mousewheel.system_scroll_override_on_root_content.vertical.factor",
> +                                                               MouseWheelRootVScrollDeltaFactor, int32_t, 100);
> +  DECL_GFX_PREF(Live, "mousewheel.system_scroll_override_on_root_content.horizontal.factor",

alphabetize, horizontal should go before vertical.
Attachment #8582778 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/e122d0043843
https://hg.mozilla.org/mozilla-central/rev/1b0655f6b110
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Depends on: 1190112
Depends on: 1213324
Depends on: 1216488
Depends on: 1364440
Depends on: 1364443
You need to log in before you can comment on or make changes to this bug.