If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix wheel events not applying root scroll delta overrides

RESOLVED FIXED in Firefox 39

Status

()

Core
Panning and Zooming
RESOLVED FIXED
3 years ago
4 months ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

(Depends on: 2 bugs)

unspecified
mozilla39
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
I messed up in bug 1141728. Windows has a default mousewheel.system_scroll_override_on_root_content.enabled value of true, with a delta multiplier of 2.0. Wheel events by default aren't going through APZ on Windows.

Easiest solution is to just honor the pref. This patch won't honor the extra gunk in nsWindow::OverrideSystemMouseScrollSpeed, but currently e10s doesn't honor it anyway since it goes through PuppetWidget.

I'm cleaning up the about:support detection of bad prefs after discovering this, since using HasUserPref() doesn't necessarily catch bad settings.
(Assignee)

Comment 1

3 years ago
Created attachment 8582778 [details] [diff] [review]
fix
Attachment #8582778 - Flags: review?(bugmail.mozilla)
Comment on attachment 8582778 [details] [diff] [review]
fix

Review of attachment 8582778 [details] [diff] [review]:
-----------------------------------------------------------------

I'd like to see this split into two patches for landing - first one does the APZ changes and removes the override_on_root_content pref from the gfxPlatform list; second one does the rest of the gfxPlatform changes.

::: gfx/thebes/gfxPrefs.h
@@ +338,5 @@
> +  DECL_GFX_PREF(Live, "mousewheel.system_scroll_override_on_root_content.enabled",
> +                                                               MouseWheelHasRootScrollDeltaOverride, bool, false);
> +  DECL_GFX_PREF(Live, "mousewheel.system_scroll_override_on_root_content.vertical.factor",
> +                                                               MouseWheelRootVScrollDeltaFactor, int32_t, 100);
> +  DECL_GFX_PREF(Live, "mousewheel.system_scroll_override_on_root_content.horizontal.factor",

alphabetize, horizontal should go before vertical.
Attachment #8582778 - Flags: review?(bugmail.mozilla) → review+
(Assignee)

Comment 3

3 years ago
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e122d0043843
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/1b0655f6b110
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/07dc430fc6a0

w/ comments addressed (forgot to include the sorting one in the first push)
https://hg.mozilla.org/mozilla-central/rev/e122d0043843
https://hg.mozilla.org/mozilla-central/rev/1b0655f6b110
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39

Updated

2 years ago
Depends on: 1190112

Updated

2 years ago
Depends on: 1213324

Updated

2 years ago
Depends on: 1216488

Updated

4 months ago
Depends on: 1364440

Updated

4 months ago
Depends on: 1364443
You need to log in before you can comment on or make changes to this bug.