1147235 - Use AppConstants in urlbarBindings.xml

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8582793 [details] [diff] [review]
patch

>diff --git a/browser/base/content/urlbarBindings.xml b/browser/base/content/urlbarBindings.xml

>             // But open ctrl/cmd clicks on autocomplete items in a new background tab.
>+            let modifier = this.AppConstants.platform == "macosx" ?
>+                           aEvent.metaKey :
>+                           aEvent.ctrlKey;

Did you test this change? This is part of the browser-autocomplete-result-popup binding, not the "urlbar" binding, so I don't think this.AppConstants will be defined here.

The rest of the patch looks fine.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch v2

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f2077f19f53

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9f2077f19f53