1147247 - Use PRErrorCodeSuccess constant instead of literal 0 to represent success in PSM xpcshell tests

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:Cykesiopka]

(In reply to David Keeler [:keeler] (use needinfo?) from Bug 996872 comment #2)
> As far as I can tell, 0 isn't a registered PRErrorCode. I think it's
> probably ok to use it to mean success, but it would be good to be more clear
> about that [...]

> [...] (I
> would say just use Cr.NS_OK, but while I think its value is 0, I'm not sure
> that's guaranteed to always be the case, and we don't want to overlap our
> PRErrorCode space.)

And indeed there are some tests that incorrectly use Cr.NS_OK, and only happen to pass because Cr.NS_OK currently has a value of 0.

Comment 1

[:Cykesiopka]

Attachment: bug1147247_PRErrorCodeSuccess-vs-literal-0_v1.patch

I'm sorry if your eyes bleed...

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecc2f2b1e9ca

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8584956 [details] [diff] [review]
bug1147247_PRErrorCodeSuccess-vs-literal-0_v1.patch

Review of attachment 8584956 [details] [diff] [review]:
-----------------------------------------------------------------

Great - thanks. I reviewed a few of the automatically-generated tests, but not all of them (the changes to generate.py look correct).

Comment 3

[:Cykesiopka]

Thanks for the review.

(Try push is in Comment 1)

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41386efec948

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/41386efec948