Pulled latest code and built fine. Tried to launch in iPhone 5 simulator and I get a failure: "fatal error: unexpectedly found nil while unwrapping an Optional value" Line 13 of Profile.swift let url = NSFileManager.defaultManager().containerURLForSecurityApplicationGroupIdentifier(ExtensionUtils.sharedContainerIdentifier())!
Sounds like fallout from st3fan's fix for our extensions?
I can't reproduce this issue. Tried with several simulator types and on two devices. Is anyone else seeing this?
I am pretty sure now that this is happening because Mark has not setup his Mac to do device builds. That means that the provisioning profiles for org.mozilla.ios.Fennec are not present. And those profiles contain the reference to the application group. As a fallback we can use ~/Documents if containerURLForSecurityApplicationGroupIdentifier() fails, but that has the side effect that the share extension does not work. This may be ok because that is only a situation that can happen when the app is run in the simulator. On a device, containerURLForSecurityApplicationGroupIdentifier, cannot fail. (Famous last words, but it would only fail if the app were packaged incorrectly with wrong or missing entitlements)
Created attachment 8585195 [details] [review] Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/288
stefan: I think we'll land a work-around to get the simulator back for contributors, but please follow-up with a longer term bug if there's more needed.
Comment on attachment 8585195 [details] [review] Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/288 Works on device.