1147270 - Extract Sync's "device name" logic to where it can be reused by the readinglist engine.

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0008-Bug-XXXXXXX-extract-Sync-s-device-name-logic-so-it-c.patch

RL needs a device name and can't rely on Sync's pref being set.  Also touches the ReadingList module to make use of it.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8582874 [details] [diff] [review]
0008-Bug-XXXXXXX-extract-Sync-s-device-name-logic-so-it-c.patch

Review of attachment 8582874 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/readinglist/ReadingList.jsm
@@ +19,5 @@
>  XPCOMUtils.defineLazyModuleGetter(this, "SQLiteStore",
>    "resource:///modules/readinglist/SQLiteStore.jsm");
>  
> +XPCOMUtils.defineLazyModuleGetter(this, "ServerClient",
> +  "resource:///modules/readinglist/ServerClient.jsm");

oops, this should not be there!

Comment 2

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/b774ced2fd97

Comment 3

[Mark Hammond [:markh] [:mhammond]]

And a trivial followup: https://hg.mozilla.org/integration/fx-team/rev/0c74761f6bdb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b774ced2fd97
https://hg.mozilla.org/mozilla-central/rev/0c74761f6bdb

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bbad6053a259
https://hg.mozilla.org/releases/mozilla-aurora/rev/cdda1e9c607d