1147316 - [Nexus 5][Homescreen]On Home edit view, press and hold an app icon to smart collection app, the "+" icon is truncated.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Shine(Leave from Mozilla)]

Attachment: logcat_1507.txt

[1.Description]:
[Nexus 5][v2.2&v3.0][Homescreen]Long press an app on Home screen to enter edit view, press and hold an app icon to smart collection app, the "+" icon on top left of smart collection is truncated.
See attachment: logcat_1507.txt & Video1.MP4
Found at: 15:07

[2.Testing Steps]: 
1. Long press an app on Home screen to enter edit view.
2. Press and hold an app icon to smart collection app.

[3.Expected Result]: 
2. The "+" icon should not be truncated.

[4.Actual Result]: 
2. The "+" icon is truncated.

[5.Reproduction build]: 
Device: Nexus5 v2.2 (affected)
Build ID               20150324002504
Gaia Revision          014d38f7ad3912b8b33cb08ce7535a5dc5aced59
Gaia Date              2015-03-23 23:27:22
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/7a9f2a248e57
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150324.041308
Firmware Date          Tue Mar 24 04:13:23 EDT 2015
Bootloader             HHZ12d

Device: Nexus5 v3.0 (affected)
Build ID               20150324160206
Gaia Revision          aebfbd998041e960cea0468533c0b5041b504850
Gaia Date              2015-03-24 17:08:51
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/264387e7e453
Gecko Version          39.0a1
Device Name            hammerhead
Firmware(Release)      5.0
Firmware(Incremental)  eng.cltbld.20150324.193526
Firmware Date          Tue Mar 24 19:35:42 EDT 2015
Bootloader             HHZ12d

Device: Flame 2.2 (unaffected)
Build ID               20150324002504
Gaia Revision          014d38f7ad3912b8b33cb08ce7535a5dc5aced59
Gaia Date              2015-03-23 23:27:22
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/7a9f2a248e57
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150324.041652
Firmware Date          Tue Mar 24 04:17:03 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]:
This problem cannot be repro on Flame 2.2.

Comment 1

[Shine(Leave from Mozilla)]

Attachment: Video1.MP4

Comment 2

[Gregor Wagner [:gwagner]]

Chris, any idea whats going on or do we need the devices team to take a look here?

Comment 3

[Chris Lord [:cwiiis]]

Looks like a style issue, or maybe a missing asset? I'll take a look.

Note, I don't actually have a Nexus 5 to run FxOS on (I have my personal one, but it's my Android backup phone for emergencies), but I wouldn't have thought I need one to diagnose this.

Comment 4

[Chris Lord [:cwiiis]]

Looks like we're missing some assets in gaia_grid:

[e-mail]
[e-mail]
[e-mail]
[e-mail]

Eric, can you get us those (homescreen) assets, or can you needinfo someone who can?

Comment 5

[Chris Lord [:cwiiis]]

A link to the directory tree, so you can see what I mean: https://github.com/mozilla-b2g/gaia/tree/master/shared/elements/gaia_grid/images

Comment 6

[Eric Pang [:epang] UX]

(In reply to Chris Lord [:cwiiis] from comment #4)
> Looks like we're missing some assets in gaia_grid:
> 
> [e-mail]
> [e-mail]
> [e-mail]
> [e-mail]
> 
> Eric, can you get us those (homescreen) assets, or can you needinfo someone
> who can?

Redirecting to Peter.  Peter can you help Chris with these assets?  I can't seem to find the loading spinner. Thanks!

Comment 7

[Peter La]

Hi Chris,

I will get these missing images to you as soon as possible.  Tomorrow latest.

Comment 8

[Peter La]

Attachment: MissingIcons-Bug1147316.zip

Hi Chris,

Here are the missing icons.  Let me know if this doesn't clear up the issue and you need further asssistance!

Thanks!

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1147316-missing-gaia-grid-icons > mozilla-b2g:master

Comment 10

[Chris Lord [:cwiiis]]

Comment on attachment 8588294 [details] [review]
[gaia] Cwiiis:bug1147316-missing-gaia-grid-icons > mozilla-b2g:master

I might not be around to add the checkin-needed keyword when you review this, if you could add that'd be much appreciated :)

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8588294 [details] [review]
[gaia] Cwiiis:bug1147316-missing-gaia-grid-icons > mozilla-b2g:master

Hm, this is odd because I have a nexus5 and can't reproduce this. We need these assets regardless, so leaving an R+ for now. Thanks!

Comment 12

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/d99294d2f3084abc4457829a1d920a8045c25938

Comment 13

[Shine(Leave from Mozilla)]

(In reply to Autolander from comment #12)
> Pull request has landed in master:
> https://github.com/mozilla-b2g/gaia/commit/
> d99294d2f3084abc4457829a1d920a8045c25938

Hi Autolander,
Could you please tell me that it landed in N5 3.0 or Flame 3.0? I find this problem is fixed on Flame 3.0, but on N5 3.0 is failed.
Thanks!

Comment 14

[Norry.L.F(Leave from Mozilla)]

Hi Kevin,

According to comment 13, Could you help to confirm whether the patch will land in N5 3.0&2.2/Flame 2.2 or not? thanks.

Comment 15

[Kevin Grandon :kgrandon]

(In reply to Norry.L.F from comment #14)
> Hi Kevin,
> 
> According to comment 13, Could you help to confirm whether the patch will
> land in N5 3.0&2.2/Flame 2.2 or not? thanks.

I don't know? I thought we were only really taking blocking issues at this point, so not really my call. If we have some partner launch at this resolution, we should consider it.

Comment 16

[Chris Lord [:cwiiis]]

Comment on attachment 8588294 [details] [review]
[gaia] Cwiiis:bug1147316-missing-gaia-grid-icons > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: This bug, I guess - Homescreen can look weird on higher-DPI-than-Flame devices?
[Testing completed]: Don't have a device to reproduce the issue, but the assets were missing and that seems like too much of a coincidence for it not to be the cause.
[Risk to taking this patch] (and alternatives if risky): Zero risk. This patch literally just adds missing files. Even if it doesn't fix the issue, we should uplift this anyway, imho.
[String changes made]: None

Comment 17

[Josh Cheng [:josh]]

Hi Shine,

We only nightly for 3.0 master/central and device build, can you confirm you really verify on the correct device build? 

Could you provide the screenshot which you verified on N5 nightly build?

Comment 18

[Shine(Leave from Mozilla)]

Attachment: N5_Nightly_video.mp4

Hi Josh,
I have verified this problem on N5_3.0 nightly build in comment 13, and this problem also can be reproduced on latest N5_3.0 nightly build.
Please see attachment: logcat_2334.txt & N5_Nightly_video.mp4
Rate: 5/5
Many thanks!

Device: N5_3.0 nightly
Build ID               20150506160205
Gaia Revision          426fe6450ab8da92bb473fef12ccb39c6c920dd0
Gaia Date              2015-05-06 08:40:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/5593ac626826
Gecko Version          40.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150506.192419
Firmware Date          Wed May  6 19:24:33 EDT 2015
Bootloader             HHZ12f

Comment 19

[Shine(Leave from Mozilla)]

Attachment: logcat_2334.txt

Comment 20

[Josh Cheng [:josh]]

Hi Chirs,
The issue seems not fixed yet on master per comment 18 from Shile. Could you please have a check again?
Thanks.

Comment 21

[Josh Cheng [:josh]]

Hi Chris, 
Just soft reminder we are still waiting for your comment. Thanks!

Comment 22

[Chris Lord [:cwiiis]]

I can replicate this on the Sony Xperia Z3C, reopening.

Comment 23

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1147316-fix-cutoff-collection-icon > mozilla-b2g:master

Comment 24

[Chris Lord [:cwiiis]]

Comment on attachment 8607025 [details] [review]
[gaia] Cwiiis:bug1147316-fix-cutoff-collection-icon > mozilla-b2g:master

background-image is of course a compound style rule, so setting background-image was overriding the prior rule's background-size.

Comment 25

[Kevin Grandon :kgrandon]

Comment on attachment 8607025 [details] [review]
[gaia] Cwiiis:bug1147316-fix-cutoff-collection-icon > mozilla-b2g:master

LGTM.

Comment 26

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/a1c099f167d778908bc45d0e1f834f5ccf97f0ba

Comment 27

[Chris Lord [:cwiiis]]

Comment on attachment 8607025 [details] [review]
[gaia] Cwiiis:bug1147316-fix-cutoff-collection-icon > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Hidpi devices will have an incorrectly sized 'add-to-collection' icon when hovering an icon over a collection.
[Testing completed]: Manual testing completed
[Risk to taking this patch] (and alternatives if risky): Zero risk
[String changes made]: None

Comment 28

[Josh Cheng [:josh]]

Hi Shine,
Please verify on master again.
Thanks!

Comment 29

[Shine(Leave from Mozilla)]

Attachment: Verify_Pass_N5_3.0.png

Hi Josh,
This problem is verified pass on latest N5_3.0 nightly build.
Actual Result: The size of "+" icon is smaller than before and the "+" icon is displayed without truncation now.
Please see attachment: Verify_Pass_N5_3.0.png
Rate: 0/5

Device: N5_3.0 nightly build (Pass)
Build ID               20150519160202
Gaia Revision          97dc139f1a690224e98533a86526c4165eed1db5
Gaia Date              2015-05-19 04:43:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4fb7ff694bf5
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150519.191919
Firmware Date          Tue May 19 19:19:36 EDT 2015
Bootloader             HHZ12f

Thanks!

Comment 30

[Josh Cheng [:josh]]

Approving and add verifyme for QA to verify on 2.2 after patch landed there

Comment 31

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/9922f77166c3876f3008afdcdbb8d2379f5de99a

Comment 32

[Shine(Leave from Mozilla)]

Attachment: Verify_Pass_N5_2.2.png

This problem is verified pass on latest N5_2.2 nightly build.
Actual Result: The size of "+" icon is smaller than before and the "+" icon is displayed without truncation now.
Please see attachment: Verify_Pass_N5_2.2.png
Rate: 0/5

Device: N5_2.2 nightly build (Pass)
Build ID               20150521162503
Gaia Revision          8099d4fbdcc659d3f6a75e98346a1214cca26802
Gaia Date              2015-05-21 14:39:42
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/fd7b06b22d00
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150521.195842
Firmware Date          Thu May 21 19:58:58 EDT 2015
Bootloader             HHZ12f

Thanks!