Closed
Bug 1147364
Opened 11 years ago
Closed 10 years ago
seamonkey-config.pp requires aws-ssh-key entry
Categories
(Infrastructure & Operations :: RelOps: Puppet, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ewong, Assigned: ewong)
Details
Attachments
(1 file)
|
953 bytes,
patch
|
dustin
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/build/puppet/rev/6b92ddc80525 now requires aws-ssh-key
to be defined. SeaMonkey doesn't use this.
Need to, for lack of a better word phrase 'fake' it in seamonkey-config.pp.
Right now, this missing entry is generating a lot of failed puppet
changes mail.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8583062 -
Flags: review?(bugspam.Callek)
|
|
Assignee | |
Updated•11 years ago
|
OS: Windows 7 → All
Guessing at triage destination.
Component: Infrastructure: Puppet → RelOps: Puppet
QA Contact: jdow → dustin
|
|
Assignee | |
Comment 3•11 years ago
|
||
Right now, all our Linux boxes are not connected to the master. I'm
not sure if this bug is the culprit though.
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8583062 [details] [diff] [review]
proposed patch (v1)
Pushed to puppet: (default)
https://hg.mozilla.org/build/puppet/rev/3e10e30d4140
|
|
Assignee | |
Comment 5•11 years ago
|
||
(In reply to Edmund Wong (:ewong) from comment #4)
> Comment on attachment 8583062 [details] [diff] [review]
> proposed patch (v1)
>
> Pushed to puppet: (default)
> https://hg.mozilla.org/build/puppet/rev/3e10e30d4140
from a rs=Callek over irc for post-push review
|
|
||
Comment 6•11 years ago
|
||
In production
https://hg.mozilla.org/build/puppet/rev/0e9d3c2d1091
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•10 years ago
|
||
Just realized that the review's still pending. Reopening..
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Updated•10 years ago
|
Status: REOPENED → ASSIGNED
|
||
Comment 8•10 years ago
|
||
Comment on attachment 8583062 [details] [diff] [review]
proposed patch (v1)
Review of attachment 8583062 [details] [diff] [review]:
-----------------------------------------------------------------
This can't have been too critical, but let's get the bug closed..
Attachment #8583062 -
Flags: review?(bugspam.Callek) → review+
|
||
Comment 9•10 years ago
|
||
Ewong, let's land this! (Resolving to get it off RelOps triage list)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 10 years ago
Flags: needinfo?(ewong)
Resolution: --- → FIXED
|
|
Assignee | |
Comment 10•10 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #9)
> Ewong, let's land this! (Resolving to get it off RelOps triage list)
I did a post-push review land, so it has landed... according to comment #6,
unless I'm missing something?
Flags: needinfo?(ewong)
You need to log in
before you can comment on or make changes to this bug.
Description
•