Closed Bug 1147373 Opened 11 years ago Closed 7 years ago

JS backquotes break syntax highlighting

Categories

(MozReview Graveyard :: General, defect, P3)

Product:
MozReview Graveyard
Component:
General
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: Yoric, Unassigned)

Details

STR (I believe) Upload a patch with a JS string that looks like `foo'` Syntax highlighting parses `foo' as the string, then ` as the beginning of a new string, which is wrong.
I doubt pygments (the library doing the highlighting) knows about your modern ES6 ways. It might be some time before it learns about all the new ES6 goodness. Perhaps Mozillians should contribute ES6 support into upstream... http://pygments.org/
Priority: -- → P2
We have too many P1s, so I'm spreading out the priorities. P3 -> P4, P2 -> P3, and some portion of P1s will become P2.
Priority: P2 → P3
Product: Developer Services → MozReview
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.