Closed
Bug 1147405
Opened 9 years ago
Closed 9 years ago
RCeil: Fix test case in dce-with-recover-instructions.js
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: nbp, Assigned: bbouvier)
References
Details
Attachments
(1 file)
1.83 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Currently, the test case written for RCeil is not used, as we are not producing any MCeil instruction but MMathFunction(Ceil). We should fix the test case and change the assertion added by Bug 1092544.
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(benj)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → benj
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(benj)
Reporter | ||
Updated•9 years ago
|
Attachment #8583829 -
Flags: review?(nicolas.b.pierron) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/366c8ef07648
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/366c8ef07648
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Comment 4•9 years ago
|
||
I think this is cause of an improvement. (Could also be one of the other two commits of you ;)). http://arewefastyet.com/regressions/#/regression/69947 misc-bugs-847389-jpeg2000: 4.25% improvement.
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Hannes Verschore [:h4writer] from comment #4) > I think this is cause of an improvement. (Could also be one of the other two > commits of you ;)). > > http://arewefastyet.com/regressions/#/regression/69947 > misc-bugs-847389-jpeg2000: 4.25% improvement. Very probably, as this implied that Math.ceil could be ion-compiled into MCeil again :) (and not into MMathFunction as previously)
You need to log in
before you can comment on or make changes to this bug.
Description
•