Closed Bug 1147405 Opened 9 years ago Closed 9 years ago

RCeil: Fix test case in dce-with-recover-instructions.js

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: nbp, Assigned: bbouvier)

References

Details

Attachments

(1 file)

Currently, the test case written for RCeil is not used, as we are not producing any MCeil instruction but MMathFunction(Ceil).

We should fix the test case and change the assertion added by Bug 1092544.
Flags: needinfo?(benj)
Assignee: nobody → benj
Status: NEW → ASSIGNED
Flags: needinfo?(benj)
Attachment #8583829 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/366c8ef07648
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
I think this is cause of an improvement. (Could also be one of the other two commits of you ;)).

http://arewefastyet.com/regressions/#/regression/69947
misc-bugs-847389-jpeg2000: 4.25% improvement.
(In reply to Hannes Verschore [:h4writer] from comment #4)
> I think this is cause of an improvement. (Could also be one of the other two
> commits of you ;)).
> 
> http://arewefastyet.com/regressions/#/regression/69947
> misc-bugs-847389-jpeg2000: 4.25% improvement.

Very probably, as this implied that Math.ceil could be ion-compiled into MCeil again :) (and not into MMathFunction as previously)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: