1147406 - mozreview UI should let reviewers start composing a global review comment from the start

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect)

Description

[Patrick Brosset <:pbro>]

When reviewing code, there are 2 types of comments you can make:
- a comment relative to a line of code
- a global comment relative to the patch/bug itself

I find myself often starting to write a global comment before I'm done reviewing all changes, and so in bugzilla for instance, I like to jump from a file diff to the global comment box, and back, as I go through the files.

On mozreview, I don't think that is possible at the moment. I see a global comment can be added by clicking on the "review" button in the toolbar, but that's after you're done with the review.

It would help reviewers (at least me) if a global comment textarea was available at all times on the review UI.

Comment 1

[Patrick Brosset <:pbro>]

Discussed with mcote on IRC:

07:43 <~mcote> pbrosset: it works fine :) You can go to the Review button at the top, type in some of your general comment, hit Save (not Publish), then go to the diff, make specific comments, save them, and then click the Edit Review button in the banner thingy
07:43 <~mcote> you'll then see your in-progress general comment and all line-specific comments
07:43 <~mcote> just make sure your general review comment and your line comments are all on the same commit/review request, and they'll all be folded into the review