114751 - Fix PSM use of nsDialogParamsBlock.cpp was: Cert Enrollment is broken when using a hardware device.

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P1)

Description

[Stephane Saux]

Using the internal Reg Authority to access certificates.netscape.com
Using an ActivCard hardware device.

Behavior is enter ldap name/pwd.
Get prompted with the key escrow dialog.
click on OK
The device chooser never appears.
The keys are not generated.
The request is not sent to the server.

Expected:
The device chooser lets you select the device you want, the keys are generated,
the request is sent.

Comment 1

[Stephane Saux]

Attachment: Patch make all of PSM code agree with nsDialogParams.cpp implementation

Whereever PSM needs to set a potentially large number of
parameters for a dialog, SetNumberStrings is called. The indexes
are now started at zero.
PSM now correctly treats Int and String indexes are separate.
I.e., 
SetInt(0,1);
SetString(0,somestring);
is ok.
The following functionality was affected:
cert picker.
client auth cert chooser,
token chooser,
delete cert (all changes in the xul/js).

Comment 2

[Stephane Saux]

kai, can you review.

Comment 3

[Kai Engert [:KaiE:]]

Comment on attachment 62134 [details] [diff] [review]
Patch make all of PSM code agree with nsDialogParams.cpp implementation

r=kaie

Comment 4

[Scott MacGregor]

Comment on attachment 62134 [details] [diff] [review]
Patch make all of PSM code agree with nsDialogParams.cpp implementation

sr=mscott

Comment 5

[Kai Engert [:KaiE:]]

checked in => fixed

Comment 6

[Stephane Saux]

*** Bug 115304 has been marked as a duplicate of this bug. ***

Comment 7

[John Unruh]

Verified.

Comment 8

[Kai Engert [:KaiE:]]

I don't want to reopen this bug, but I found something related. PSM uses a
subclass of nsDialogParamBlock, named nsPKIParamBlock.

The implementation of that class adds the ability to pass an array of pointers.
It has hardcoded to subtract -1 from the given index. In order to be consistent,
it might make sense to adjust the security code, in order to be consistent with
nsDialogParamBlock.

On the other hand, this classes uses a dynamic array, and passing a zero index
might not work, anyway.

Comment 9

[Stephane Saux]

I think I looked at this and I don't think I saw "wrong code". Fixing it just to
be consistent is too much work and risk.