Closed Bug 1147642 Opened 6 years ago Closed 6 years ago

TypedArray regression from Bug 1139769 breaks JSZip

Categories

(Core :: JavaScript: Standard Library, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1145058

People

(Reporter: justindarc, Unassigned)

References

Details

The patch in attachment 8573096 [details] [diff] [review] that landed as part of Bug 1139769 has broken JSZip ( http://stuk.github.io/jszip/ ).

This was discovered in https://github.com/fxos/addon-generator while developing the Gaia Customizer add-on. When attachment 8573096 [details] [diff] [review] landed, the aforementioned addon-generator stopped producing valid zip files.

A somewhat reduced test case that illustrates the problem can be found here: http://jsbin.com/hogaze

If you run the above test case on latest mozilla-central, the ZIP file produced by clicking the "Download Add-on" link is corrupt. However, if you run the above test case on aurora/developer edition, B2G v2.2, or mozilla-central prior to the landing of attachment 8573096 [details] [diff] [review], the generated ZIP file is valid.

No errors are reported in the console and the JSZip library appears to continue functioning as intended, although the content it generates is corrupt.
See Also: → 1139769
Blocks: 1139769
Flags: needinfo?(jwalden+bmo)
See Also: 1139769
I spoke to Waldo and this is possibly a dupe of Bug 1145058. Let's re-test when it lands on nightly.
Flags: needinfo?(jwalden+bmo)
Depends on: 1145058
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1145058
You need to log in before you can comment on or make changes to this bug.