Closed Bug 1147656 Opened 8 years ago Closed 8 years ago

Make the profiler's buffer bigger

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox39 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: fitzgen, Assigned: jsantell)

References

Details

Attachments

(2 files)

Make the profiler's buffer bigger
1.09 KB, patch
jsantell
: review+
djvj
: review+
Details | Diff | Splinter Review
1147656-remove-profiler-defaults.patch
2.19 KB, patch
vporof
: review+
Details | Diff | Splinter Review 
Even with making it 10x larger, I can still fill it in ~5 seconds, but I'm hesitant to make it even bigger without more discussion...
Attachment #8583436 - Flags: review?(jsantell)
Comment on attachment 8583436 [details] [diff] [review]
Make the profiler's buffer bigger

Review of attachment 8583436 [details] [diff] [review]:
-----------------------------------------------------------------

Shame that an order of magnitude still doesn't make this better :\
Attachment #8583436 - Flags: review?(jsantell) → review+
I really think we should ask :djvj to review this as well.
Attachment #8583436 - Flags: review?(kvijayan)
Comment on attachment 8583436 [details] [diff] [review]
Make the profiler's buffer bigger

Review of attachment 8583436 [details] [diff] [review]:
-----------------------------------------------------------------

So a ProfileEntry is 9 bytes on a platform, so making this buffer 10million in size means we're allocating a 90-meg buffer for profiling.  Should be fine, as dev machines are large, but we may want to make this tunable in the future.
Attachment #8583436 - Flags: review?(kvijayan) → review+
(In reply to Kannan Vijayan [:djvj] from comment #4)
> Comment on attachment 8583436 [details] [diff] [review]
> Make the profiler's buffer bigger
> 
> Review of attachment 8583436 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> So a ProfileEntry is 9 bytes on a platform, so making this buffer 10million
> in size means we're allocating a 90-meg buffer for profiling.  Should be
> fine, as dev machines are large, but we may want to make this tunable in the
> future.

Bug 1147945
Remove front setting defaults on profiler
Assignee: nfitzgerald → jsantell
Attachment #8584026 - Flags: review?(vporof)
Attachment #8584026 - Flags: review?(vporof) → review+
https://hg.mozilla.org/mozilla-central/rev/0ac8484970b4
https://hg.mozilla.org/mozilla-central/rev/80c76b3ecd46
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox39: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.