1147656 - Make the profiler's buffer bigger

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Even with making it 10x larger, I can still fill it in ~5 seconds, but I'm hesitant to make it even bigger without more discussion...

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Make the profiler's buffer bigger

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8583436 [details] [diff] [review]
Make the profiler's buffer bigger

Review of attachment 8583436 [details] [diff] [review]:
-----------------------------------------------------------------

Shame that an order of magnitude still doesn't make this better :\

Comment 3

[Victor Porof [:vporof][:vp]]

I really think we should ask :djvj to review this as well.

Comment 4

[Kannan Vijayan [:djvj]]

Comment on attachment 8583436 [details] [diff] [review]
Make the profiler's buffer bigger

Review of attachment 8583436 [details] [diff] [review]:
-----------------------------------------------------------------

So a ProfileEntry is 9 bytes on a platform, so making this buffer 10million in size means we're allocating a 90-meg buffer for profiling.  Should be fine, as dev machines are large, but we may want to make this tunable in the future.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to Kannan Vijayan [:djvj] from comment #4)
> Comment on attachment 8583436 [details] [diff] [review]
> Make the profiler's buffer bigger
> 
> Review of attachment 8583436 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> So a ProfileEntry is 9 bytes on a platform, so making this buffer 10million
> in size means we're allocating a 90-meg buffer for profiling.  Should be
> fine, as dev machines are large, but we may want to make this tunable in the
> future.

Bug 1147945

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1147656-remove-profiler-defaults.patch

Remove front setting defaults on profiler

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=28df32adfd5c

Comment 8

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/0ac8484970b4
https://hg.mozilla.org/mozilla-central/rev/80c76b3ecd46