1147665 - Convert MarkValue family of functions over to TraceEdge

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: 4.4_remove_mark_value_family-v0.diff

Trivial except for the pre-barrier's marker. It needs a special forward declaration anyway, so I've added an assert that we're not pre-barriering while isHeapBusy.

Comment 1

[Jon Coppeard (:jonco) (PTO until 3rd April)]

Comment on attachment 8583466 [details] [diff] [review]
4.4_remove_mark_value_family-v0.diff

Review of attachment 8583466 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/Marking.h
@@ -247,1 @@
>  MarkThingOrValueUnbarriered(JSTracer *trc, uintptr_t *word, const char *name);

What on earth is this?  Oh it doesn't seem to be defined.  Might as well remove this too.

Comment 2

[Terrence Cole [:terrence]]

(In reply to Jon Coppeard (:jonco) from comment #1)
> Comment on attachment 8583466 [details] [diff] [review]
> 4.4_remove_mark_value_family-v0.diff
> 
> Review of attachment 8583466 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/gc/Marking.h
> @@ -247,1 @@
> >  MarkThingOrValueUnbarriered(JSTracer *trc, uintptr_t *word, const char *name);
> 
> What on earth is this?  Oh it doesn't seem to be defined.  Might as well
> remove this too.

Thanks for checking that out! I was going to dig into it today, but now I don't have to.

Comment 3

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1216bd1e667e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a9d166af96b

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffe7f2e2a0f0

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/99415fbccf83 because something in this push caused frequent 10.10 debug devtools-2 assertion failures like https://treeherder.mozilla.org/logviewer.html#?job_id=8197104&repo=mozilla-inbound

Comment 5

[Terrence Cole [:terrence]]

The problem before was in the last patch in the series (bug 1147670):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=514b9ba692a9
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad8cd4aaa143

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ad8cd4aaa143