Convert MarkValue family of functions over to TraceEdge

RESOLVED FIXED in Firefox 40

Status

()

Core
JavaScript: GC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla40
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8583466 [details] [diff] [review]
4.4_remove_mark_value_family-v0.diff

Trivial except for the pre-barrier's marker. It needs a special forward declaration anyway, so I've added an assert that we're not pre-barriering while isHeapBusy.
Attachment #8583466 - Flags: review?(jcoppeard)
Comment on attachment 8583466 [details] [diff] [review]
4.4_remove_mark_value_family-v0.diff

Review of attachment 8583466 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/Marking.h
@@ -247,1 @@
>  MarkThingOrValueUnbarriered(JSTracer *trc, uintptr_t *word, const char *name);

What on earth is this?  Oh it doesn't seem to be defined.  Might as well remove this too.
Attachment #8583466 - Flags: review?(jcoppeard) → review+
(Assignee)

Comment 2

3 years ago
(In reply to Jon Coppeard (:jonco) from comment #1)
> Comment on attachment 8583466 [details] [diff] [review]
> 4.4_remove_mark_value_family-v0.diff
> 
> Review of attachment 8583466 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/gc/Marking.h
> @@ -247,1 @@
> >  MarkThingOrValueUnbarriered(JSTracer *trc, uintptr_t *word, const char *name);
> 
> What on earth is this?  Oh it doesn't seem to be defined.  Might as well
> remove this too.

Thanks for checking that out! I was going to dig into it today, but now I don't have to.
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/99415fbccf83 because something in this push caused frequent 10.10 debug devtools-2 assertion failures like https://treeherder.mozilla.org/logviewer.html#?job_id=8197104&repo=mozilla-inbound
https://hg.mozilla.org/mozilla-central/rev/ad8cd4aaa143
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Depends on: 1151155
You need to log in before you can comment on or make changes to this bug.