1147679 - Consider using PR_GetFileInfo64 when deserializing heap snapshots

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

> ::: toolkit/devtools/server/ChromeUtils.cpp
> @@ +404,5 @@
> > +    return nullptr;
> > +  }
> > +
> > +  PRFileInfo fileInfo;
> > +  if (PR_GetFileInfo(path.get(), &fileInfo) != PR_SUCCESS) {
> 
> For the future: consider using PR_GetFileInfo64 (and dealing with issues of
> conversion to size_t on 32-bit machines).

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Use PR_GetFileInfo64 when deserializing heap snapshots

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f2fdcefa7db

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3dc2e5481e1a

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3dc2e5481e1a