Closed Bug 1147679 Opened 6 years ago Closed 6 years ago

Consider using PR_GetFileInfo64 when deserializing heap snapshots

Categories

(DevTools :: Memory, defect)

x86
macOS
defect
Not set
normal

Tracking

(firefox41 fixed)

RESOLVED FIXED
Firefox 41
Tracking Status
firefox41 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file)

> ::: toolkit/devtools/server/ChromeUtils.cpp
> @@ +404,5 @@
> > +    return nullptr;
> > +  }
> > +
> > +  PRFileInfo fileInfo;
> > +  if (PR_GetFileInfo(path.get(), &fileInfo) != PR_SUCCESS) {
> 
> For the future: consider using PR_GetFileInfo64 (and dealing with issues of
> conversion to size_t on 32-bit machines).
Assignee: nobody → nfitzgerald
Attachment #8614890 - Flags: review?(jimb)
Attachment #8614890 - Flags: review?(jimb) → review+
https://hg.mozilla.org/mozilla-central/rev/3dc2e5481e1a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.