1147683 - Consider choosing a good inline capacity for DeserializedNode::EdgeVector

Status: RESOLVED WORKSFORME

(DevTools :: Memory, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

> ::: toolkit/devtools/server/DeserializedNode.h
> @@ +51,5 @@
> > +
> > +// A `DeserializedNode` is a node in the heap graph that we deserialized from a
> > +// core dump.
> > +struct DeserializedNode {
> > +  using EdgeVector = Vector<DeserializedEdge>;
> 
> Here is a case where choosing a good MinInlineCapacity (second template arg)
> could make a big difference. But let's get data first.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Took the average for each inline capacity N over 50 runs reading the same full
process heap snapshot of one tab loaded to cnn.com:

N  | Avg. Time (ms)
---+---------------
0  | 1815.10
1  | 1878.76
2  | 1907.86
3  | 1943.66
4  | 1887.62
6  | 1874.02
8  | 1935.78
16 | 2002.17

I don't think there is anything to do here.