Consider choosing a good inline capacity for DeserializedNode::EdgeVector

RESOLVED WORKSFORME

Status

RESOLVED WORKSFORME
3 years ago
2 months ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

> ::: toolkit/devtools/server/DeserializedNode.h
> @@ +51,5 @@
> > +
> > +// A `DeserializedNode` is a node in the heap graph that we deserialized from a
> > +// core dump.
> > +struct DeserializedNode {
> > +  using EdgeVector = Vector<DeserializedEdge>;
> 
> Here is a case where choosing a good MinInlineCapacity (second template arg)
> could make a big difference. But let's get data first.
Assignee: nobody → nfitzgerald
Took the average for each inline capacity N over 50 runs reading the same full
process heap snapshot of one tab loaded to cnn.com:

N  | Avg. Time (ms)
---+---------------
0  | 1815.10
1  | 1878.76
2  | 1907.86
3  | 1943.66
4  | 1887.62
6  | 1874.02
8  | 1935.78
16 | 2002.17

I don't think there is anything to do here.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WORKSFORME

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.