[EME] Backout eme-decrypt-v6 API back compatibility

RESOLVED FIXED in Firefox 41

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: eflores, Assigned: cpearce)

Tracking

(Blocks: 1 bug)

unspecified
mozilla41
x86_64
Windows 8.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment)

In bug 1147689 we will be incrementing the eme-decrypt API version to v7, but will be hacking in back-compatibility with eme-decrypt-v6 for a smooth transition.

We should back that patch out as soon as eme-decrypt-v6 is no longer used.
(Assignee)

Updated

3 years ago
Blocks: 1015800
(Assignee)

Comment 1

3 years ago
Created attachment 8624581 [details] [diff] [review]
Patch

It's about time methinks...
Assignee: edwin → cpearce
Status: NEW → ASSIGNED
Attachment #8624581 - Flags: review?(edwin)
Attachment #8624581 - Flags: review?(edwin) → review+
(Assignee)

Updated

3 years ago
Blocks: 1177461
(Assignee)

Comment 4

3 years ago
Comment on attachment 8624581 [details] [diff] [review]
Patch

Review of attachment 8624581 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/eme/MediaKeySystemAccess.cpp
@@ +261,2 @@
>           (!hasH264 ||
> +          HaveGMPFor(aGMPS,

Edwin pointed out that I deleted the '!' here, that's what causes the test to fail.
https://hg.mozilla.org/mozilla-central/rev/ba5f47ced259
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(Assignee)

Comment 7

3 years ago
Beta try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=588abc33bda3

(This is fixed on Aurora already)
Flags: needinfo?(cpearce)
(Assignee)

Comment 8

3 years ago
It's looking like we won't need this uplifted...
Flags: needinfo?(cpearce)
You need to log in before you can comment on or make changes to this bug.