Closed Bug 1147692 Opened 5 years ago Closed 4 years ago

[EME] Backout eme-decrypt-v6 API back compatibility

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: eflores, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In bug 1147689 we will be incrementing the eme-decrypt API version to v7, but will be hacking in back-compatibility with eme-decrypt-v6 for a smooth transition.

We should back that patch out as soon as eme-decrypt-v6 is no longer used.
Blocks: EME
Attached patch PatchSplinter Review
It's about time methinks...
Assignee: edwin → cpearce
Status: NEW → ASSIGNED
Attachment #8624581 - Flags: review?(edwin)
Attachment #8624581 - Flags: review?(edwin) → review+
Blocks: 1177461
Comment on attachment 8624581 [details] [diff] [review]
Patch

Review of attachment 8624581 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/eme/MediaKeySystemAccess.cpp
@@ +261,2 @@
>           (!hasH264 ||
> +          HaveGMPFor(aGMPS,

Edwin pointed out that I deleted the '!' here, that's what causes the test to fail.
https://hg.mozilla.org/mozilla-central/rev/ba5f47ced259
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Beta try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=588abc33bda3

(This is fixed on Aurora already)
Flags: needinfo?(cpearce)
It's looking like we won't need this uplifted...
Flags: needinfo?(cpearce)
You need to log in before you can comment on or make changes to this bug.