1147693 - Show meta category nodes instead of filtering them out in the flame graph

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Like bug 1108843, but for the flame graph.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1147693-flamegraphmeta.patch

Needs tests. flame graph utils tests are the worst.

Comment 2

[Shu-yu Guo [:shu]]

I think I fixed this with bug 1154115.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

This looks like it's good to go -- but not sure if we have tests for this?

Comment 4

[Shu-yu Guo [:shu]]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #3)
> This looks like it's good to go -- but not sure if we have tests for this?

Kinda. Some of the old flame graph tests were asserting on the exact output of that buildFlameGraphDataFromSamples function or whatever it's called. Since that function now outputs metacategories, I had to change those tests to expect those new nodes.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

SGTM.

Comment 6

[Brian Grinstead [:bgrins]]

This doesn't need an uplift, right?  Looks like it's been resolved without a changeset

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Correct, was fixed as a part of shu's rewrite