DisplayItemClip::ApplyNonRoundedIntersection doesn't intersect correctly

RESOLVED FIXED in Firefox 39

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: seth, Assigned: seth)

Tracking

unspecified
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The patch in bug 1147706 made it apparent that we have a bug in DisplayItemClip::ApplyNonRoundedIntersection. See here:

https://dxr.mozilla.org/mozilla-central/source/layout/base/DisplayItemClip.cpp?from=ApplyNonRoundedIntersection&case=true#330

That line of code doesn't do anything, because Intersect() returns a new rect which we immediately destroy.
(Assignee)

Comment 1

4 years ago
Created attachment 8583526 [details] [diff] [review]
Intersect correctly in DisplayItemClip::ApplyNonRoundedIntersection

Here's the patch.
Attachment #8583526 - Flags: review?(roc)
Comment on attachment 8583526 [details] [diff] [review]
Intersect correctly in DisplayItemClip::ApplyNonRoundedIntersection

Review of attachment 8583526 [details] [diff] [review]:
-----------------------------------------------------------------

OW!
Attachment #8583526 - Flags: review?(roc) → review+
https://hg.mozilla.org/mozilla-central/rev/950e7c72280a
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.