Closed Bug 1147716 Opened 7 years ago Closed 7 years ago
_mcb _redirect .js is going to permafail when Gecko 39 merges to Aurora
Tracking for 39. Tanvi if you take this can you assign yourself to the bug? Thanks.
Assignee: nobody → tanvi
This is odd. The tests written in browser_mcb_redirect.js actually complete successfully. But we are getting an TEST-UNEXPECTED-FAIL because of a test that was run previously - browser_bug435325.js. Looking at the logs and browser.ini, the other test runs quite a bit before browser_mcb_redirect.js. The only thing in common between the two is that they are the only tests in browser/base/content/test/general that go into offline mode. Looking at browser_bug435325.js, I don't see anything wrong with it's use of ok() here, as the error suggests - https://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/general/browser_bug435325.js#60 I've applied a patch from Ryan to make my local build Aurora. Running browser_mcb_redirect.js shows no failures. Now I'm running all of browser/base/content/test/general to see if that helps reproduce this failure. Cc'ing Jim Mathias because he made the changes at browser_bug435325.js:60. Jim, do you have any insight as to what is going on here?  https://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/general/browser.ini#176 and https://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/general/browser.ini#492  TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_mcb_redirect.js | uncaught exception - ReferenceError: ok is not defined at chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug435325.js:60
Crap, totally my fault with that test edit - we need to remove that observer when we get the callback, it's still active: Services.obs.removeObserver(observer, "network:offline-status-changed", false); should fix it.
I've confirmed that with the patch the two tests run consecutively pass. And without the patch we get the failures in the original logs.
Pushed to inbound - https://hg.mozilla.org/integration/mozilla-inbound/rev/a489d18b4df2
You need to log in before you can comment on or make changes to this bug.