1147716 - browser_mcb_redirect.js is going to permafail when Gecko 39 merges to Aurora

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Test permafail on Monday's uplift to Aurora.

https://treeherder.mozilla.org/logviewer.html#?job_id=5924725&repo=try

23:03:41 INFO - 501 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_mcb_redirect.js | uncaught exception - ReferenceError: ok is not defined at chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug435325.js:60
23:03:41 INFO - Stack trace:
23:03:41 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1476
23:03:41 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_mcb_redirect.js:test5:186
23:03:41 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_mcb_redirect.js:waitForCondition/moveOn:96
23:03:41 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_mcb_redirect.js:waitForCondition/interval<:91
23:03:41 INFO - null:null:0
23:03:41 INFO - JavaScript error: chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug435325.js, line 60: ReferenceError: ok is not defined
23:03:41 INFO - 502 INFO Console message: [JavaScript Error: "ReferenceError: ok is not defined" {file: "chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug435325.js" line: 60}] 

etc

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 39. Tanvi if you take this can you assign yourself to the bug? Thanks.

Comment 2

[Tanvi Vyas[:tanvi]]

Investigating.

Comment 3

[Tanvi Vyas[:tanvi]]

This is odd.

The tests written in browser_mcb_redirect.js actually complete successfully.

But we are getting an TEST-UNEXPECTED-FAIL because of a test that was run previously - browser_bug435325.js.  Looking at the logs and browser.ini, the other test runs quite a bit before browser_mcb_redirect.js[1].  The only thing in common between the two is that they are the only tests in browser/base/content/test/general that go into offline mode.

Looking at browser_bug435325.js, I don't see anything wrong with it's use of ok() here, as the error[2] suggests - https://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/general/browser_bug435325.js#60

I've applied a patch from Ryan to make my local build Aurora.  Running browser_mcb_redirect.js shows no failures.  Now I'm running all of browser/base/content/test/general to see if that helps reproduce this failure.

Cc'ing Jim Mathias because he made the changes at browser_bug435325.js:60.  Jim, do you have any insight as to what is going on here?


[1] https://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/general/browser.ini#176
and https://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/general/browser.ini#492

[2] TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_mcb_redirect.js | uncaught exception - ReferenceError: ok is not defined at chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug435325.js:60

Comment 4

[Jim Mathies [:jimm]]

Crap, totally my fault with that test edit - we need to remove that observer when we get the callback, it's still active:

Services.obs.removeObserver(observer, "network:offline-status-changed", false);

should fix it.

Comment 5

[Tanvi Vyas[:tanvi]]

Attachment: Bug1147716-03-26-15.patch

Comment 6

[Tanvi Vyas[:tanvi]]

I've confirmed that with the patch the two tests run consecutively pass.  And without the patch we get the failures in the original logs.

Comment 7

[Tanvi Vyas[:tanvi]]

Pushed to inbound - https://hg.mozilla.org/integration/mozilla-inbound/rev/a489d18b4df2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a489d18b4df2