Closed Bug 1147737 Opened 5 years ago Closed 5 years ago

duplicate Selection.h entry in layout/generic/moz.build

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: heycam, Assigned: heycam)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #8583586 - Flags: review?(dholbert)
Comment on attachment 8583586 [details] [diff] [review]
patch

Hmm, so the remaining instance of this file in moz.build is:
> 96 EXPORTS.mozilla.dom += [
> 97     'Selection.h',
> 98 ]

...which means #includers have to do:
  #include "mozilla/dom/Selection.h"
...which seems a bit odd, for a file that lives in layout/generic. I guess that's because its contents have "namespace mozilla { namespace dom { } }" wrapped around them?

Anyway, given that everyone who includes this file already seems to use this (semi-misleading) mozilla/dom path in their #include statement already[1], it seems reasonable to keep the EXPORTS chunk that preserves the functionality of that use-case. So, a slightly-confused r=me.

[1] http://mxr.mozilla.org/mozilla-central/search?string=mozilla%2Fdom%2FSelection.h
Attachment #8583586 - Flags: review?(dholbert) → review+
Yeah, there are a few classes under layout/style/ that are in the mozilla::dom namespace and exported accordingly.  But not many.
https://hg.mozilla.org/mozilla-central/rev/d147d4deba0d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.