1147750 - Pretty print fails with error on long WP script

Status: RESOLVED INVALID

(DevTools :: Debugger, defect, P3)

Description

[Luke]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20150322133451

Steps to reproduce:

Clicked an exception that went to load-scripts.php of Wordpress 4.2


Actual results:

I got exception instead:
Error loading source:
Error: Unterminated string constant (5326:0)
raise@resource://gre/modules/devtools/acorn/acorn.js:334:15
readString@resource://gre/modules/devtools/acorn/acorn.js:1113:11
getTokenFromCode@resource://gre/modules/devtools/acorn/acorn.js:896:1
readToken@resource://gre/modules/devtools/acorn/acorn.js:942:15
getToken@resource://gre/modules/devtools/acorn/acorn.js:228:7
prettyFast@resource://gre/modules/devtools/pretty-fast.js:786:15
self.onmessage@resource://gre/modules/devtools/server/actors/pretty-print-worker.js:37:24

Stack: SourceActor.prototype._sendToPrettyPrintWorker/</onReply@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/script.js:2541:27
Line: 2541, column: 26


Expected results:

It should at least show the script (IF invalid). On reload it shows this script fine, so it's likely a problem from clicking the exception that linked to it.

Comment 1

[Julien Wajsberg [:julienw]]

NI Honza to check if this still happens with the new debugger.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

It isn't clear how to follow STR in comment #0

And there is no way to ask the original reporter since the account has been disabled.

It seems to me that we can close this, but to make sure, Logan. Is this something we should keep open?


Honza

Comment 3

[Logan Smyth [:loganfsmyth]]

Realistically without a reproduction example I don't thing we can move forward.