Closed
Bug 1147770
Opened 9 years ago
Closed 9 years ago
datetime element's picker is not support literal 'T' and 'Z'.
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: mantaroh, Assigned: mantaroh)
Details
Attachments
(1 file, 2 obsolete files)
2.52 KB,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
Hi wesj, this bug is fork bug 1120108. I have a question about datetime element's datetime picker. Datetime element should allow several value. (RFC3339) - yyyy-MM-ddTHH:mm:ssZ (UTC) - yyyy-MM-ddTHH:mm:ss+09:00 (UTC+9) specification is here[1]. Fennec Actual Result: - Selected value isn't include literal 'T' and 'Z'. - Selected value is UTC always. Fennec Expected Result: - Selected value support RFC3339. (should include literal 'T' and 'Z'.) Question: 1) Is datetime element's datetime picker support timezone? (this is meaning that add timezone choice element in picker UI) I think that we should support timezone. Because user will confuse if display utc timezone. If we support only utc, The name 'datetime' is wrong. it should named 'datetime-utc'. Same problem is discussed chromium / WhatWG. [2][3] [1] http://www.w3.org/TR/html-markup/input.datetime.html [2] http://lists.w3.org/Archives/Public/public-whatwg-archive/2012Nov/thread.html#msg119 [3] https://code.google.com/p/chromium/issues/detail?id=175080 best.
Flags: needinfo?(wjohnston)
Comment 1•9 years ago
|
||
Interesting. The thread in [2] makes it sound like there's some concensus to just just local datetime for "datetime" elements. But regardless, I think you're right, we should add the timezone info in this case. Lets split this in two if you want to do it. 1.) Make a new bug for creating a timezone picker widget. Lets do that somewhere separate. Ideally, we'd use a map or something, but that's not something I want to spend time on. I think we should just create a spinner and populate it with the list from TimeZone.getAvailableIDs() [1] 2.) Make sure we're formatting things correctly (in UTC orignally, and then with the timezone info when/if we have it). I'm confused from this about that a bit, but it looks like we just need to make sure the 'T' and Z formatting options are included in the date time formatter here: [2] [1] http://developer.android.com/reference/java/util/TimeZone.html#getAvailableIDs%28%29 [2] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/prompts/PromptInput.java#262
Flags: needinfo?(wjohnston)
Assignee | ||
Comment 2•9 years ago
|
||
Hi wesj, Sorry for my late reply. >Lets split this in two if you want to do it. OK. This bug is adding literal 'T' and 'Z'. and, I create another bug for creating a timezone picker widget.(bug 1156224) best regard.
Assignee | ||
Comment 3•9 years ago
|
||
Hi wesj. Created patch for this bug. I concern that this modification is relate bug 1120108. So if you can, could you add review+ flags for bug 112108?
Attachment #8600200 -
Flags: review?(wjohnston)
Assignee | ||
Comment 4•9 years ago
|
||
I submitted wrong file. Resubmit correct patch.
Attachment #8600200 -
Attachment is obsolete: true
Attachment #8600200 -
Flags: review?(wjohnston)
Attachment #8600211 -
Flags: review?(wjohnston)
Assignee | ||
Comment 5•9 years ago
|
||
sorry many time.. I submitted wrong file too.(Copy miss from VM). This patch is correct file.
Attachment #8600211 -
Attachment is obsolete: true
Attachment #8600211 -
Flags: review?(wjohnston)
Attachment #8600217 -
Flags: review?(wjohnston)
Comment 6•9 years ago
|
||
Comment on attachment 8600217 [details] [diff] [review] 1147770.patch Review of attachment 8600217 [details] [diff] [review]: ----------------------------------------------------------------- I think this looks right. Thanks :)
Attachment #8600217 -
Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/e8723577fd63
Assignee: nobody → mantaroh
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•